Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group code actions by type #38623

Closed
jrieken opened this issue Nov 17, 2017 · 1 comment
Closed

Group code actions by type #38623

jrieken opened this issue Nov 17, 2017 · 1 comment
Assignees
@jrieken
Labels
editor-code-actions Editor inplace actions (Ctrl + .) feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
January 2018

Comments

@jrieken
Copy link
Member

jrieken commented Nov 17, 2017

CodeActions can be a quick fix for a compile error/warning or the trigger for a refactoring, like extracting a method. We should reflect that in the UI and group code actions by their type. Also fixes should be sorted on top of 'normal' code actions.
@jrieken jrieken self-assigned this Nov 17, 2017
@jrieken jrieken added editor-code-actions Editor inplace actions (Ctrl + .) feature-request Request for new features or functionality labels Nov 17, 2017
@jrieken jrieken added this to the November 2017 milestone Nov 17, 2017
@jrieken
Copy link
Member Author

jrieken commented Nov 21, 2017 •
edited

fyi @tsalinger

tsalinger pushed a commit to tsalinger/vscode that referenced this issue Nov 22, 2017
@vsajan
Fix microsoft#38623
17f12b6 
CodeActions are sorted by type
@jrieken jrieken modified the milestones: November 2017, December 2017 Dec 4, 2017
jrieken added a commit that referenced this issue Dec 4, 2017
@jrieken
add test skeleton, #38623
c243d0b
@jrieken jrieken mentioned this issue Dec 11, 2017
Closed
tsalinger pushed a commit to tsalinger/vscode that referenced this issue Dec 12, 2017
@vsajan
Fix microsoft#38623
4ff607d
tsalinger pushed a commit to tsalinger/vscode that referenced this issue Dec 12, 2017
@vsajan
Fix microsoft#38623
2c6e593 
Only sort by diagnostics.
@jrieken jrieken closed this as completed Dec 13, 2017
jrieken added a commit that referenced this issue Dec 13, 2017
@jrieken
Merge pull request #38924 from tsalinger/fix38623
34445c9 
Fix #38623
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 29, 2018
@jrieken jrieken added the verification-needed Verification of issue is requested label Jan 29, 2018
@chrmarti chrmarti added the verified Verification succeeded label Feb 1, 2018
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@jrieken
Merge pull request microsoft#38924 from tsalinger/fix38623
dd78e98 
Fix microsoft#38623
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
editor-code-actions Editor inplace actions (Ctrl + .) feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
2 participants
@jrieken @chrmarti