@bpasero I was looking into implementing this and wanted to check when is the window reload necessery now? Is it ever needed? When going from purple vscode to workspace is it needed?
I think it is needed because the current open dialog always reloads, and if that is the case I would need to reload here also on drop. Should I just trigger a reload after I add a folder to the workspace or is there more?

Strangely I get a method not implemented error If I doing everything without a reload

  ERR Method not implemented.: Error: Method not implemented.
    at MainThreadComments.dispose (file:///Users/isidor/Development/vscode/out/vs/workbench/api/electron-browser/mainThreadComments.js:139:19)
    at ExtensionHostProcessManager.dispose (file:///Users/isidor/Development/vscode/out/vs/workbench/services/extensions/electron-browser/extensionService.js:145:30)
    at ExtensionService._stopExtensionHostProcess (file:///Users/isidor/Development/vscode/out/vs/workbench/services/extensions/electron-browser/extensionService.js:287:55)
    at ExtensionService.stopExtensionHost (file:///Users/isidor/Development/vscode/out/vs/workbench/services/extensions/electron-browser/extensionService.js:282:18)
    at WorkspaceEditingService.doEnterWorkspace (file:///Users/isidor/Development/vscode/out/vs/workbench/services/workspace/node/workspaceEditingService.js:150:35)
    at WorkspaceEditingService.createAndEnterWorkspace (file:///Users/isidor/Development/vscode/out/vs/workbench/services/workspace/node/workspaceEditingService.js:114:25)
    at WorkspaceEditingService.doAddFolders (file:///Users/isidor/Development/vscode/out/vs/workbench/services/workspace/node/workspaceEditingService.js:87:29)
    at WorkspaceEditingService.addFolders (file:///Users/isidor/Development/vscode/out/vs/workbench/services/workspace/node/workspaceEditingService.js:72:25)
    at HTMLDivElement.<anonymous> (file:///Users/isidor/Development/vscode/out/vs/workbench/parts/files/electron-browser/views/emptyView.js:71:47)

@isidorn that error seems to be from the recently pushed changes for PR reviews (@rebornix). A window reload is not needed if the dropped folders form a new untitled workspace, however not sure we want to do that all the time. E.g. if you drop just one folder, it would make sense to me that the window reloads to open that folder. If multiple folders are dropped, then we can transition into an untitled workspace. I think that code already exists when you drop folder(s) into the explorer.

@bpasero thanks, however there is no code that does this afaik. Since in the explorer we are always at least in one folder so we always go to a workspace when adding.
I agree that the behavior would be better if only one file is dropped that it is not opened in the workspace. What is the API to do this? Could not find it since there are too many variations of workspace mutation commands

@rebornix do you need a seperate issue for the bug mentioned here?

@isidorn thanks, I'll fix the exception real quick.

@isidorn IWindowService.openWindow() probably with the forceReuseWindow option set to true.

Btw there is a helper method to handle the drop of files or folders here: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/browser/dnd.ts#L172. If you use that one, it automatically takes care of:

• opening 1 folder if its just one
• creating a workspace for multiple folders
• opening a workspace if the dropped file is a workspace

@bpasero thanks, this simplifies things a lot, was not aware of that helper class.