Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs: dragging tabs around causes the cursor to flicker a lot #38753

Closed
bpasero opened this issue Nov 20, 2017 · 1 comment
Closed

Tabs: dragging tabs around causes the cursor to flicker a lot #38753

bpasero opened this issue Nov 20, 2017 · 1 comment
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities polish Cleanup and polish issue verified Verification succeeded workbench-dnd Drag-and-drop issues
Milestone
November 2017

Comments

@bpasero
Copy link
Member

bpasero commented Nov 20, 2017

Looks like many drag-leave events are generated when hovering over tabs and each transition causes the cursor to briefly change to a stop sign.

If someone has ideas how to solve that other than adding a full overlay over all the tabs to capture all the mouse events (as we do for the editor), please speak up.
@bpasero bpasero self-assigned this Nov 20, 2017
@vscodebot vscodebot bot added editor editor-core Editor basic functionality labels Nov 20, 2017
@bpasero bpasero added polish Cleanup and polish issue workbench-dnd Drag-and-drop issues bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities and removed editor editor-core Editor basic functionality labels Nov 20, 2017
@bpasero bpasero added this to the November 2017 milestone Nov 22, 2017
@bpasero
Copy link
Member Author

bpasero commented Nov 22, 2017 •
edited

Found a fix by disabling pointer-events in tab child elements as long as the drag operation is ongoing. There is still one slight flicker when dragging from one tab to the other simply because there seems to be a boundary between that triggers another drag-leave event.

@roblourens roblourens added the verified Verification succeeded label Dec 6, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities polish Cleanup and polish issue verified Verification succeeded workbench-dnd Drag-and-drop issues
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
2 participants
@roblourens @bpasero