Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"editor.tokenColorCustomizations" for types doesn't work in .c files. #38822

Closed
Splike opened this issue Nov 20, 2017 · 2 comments
Closed

"editor.tokenColorCustomizations" for types doesn't work in .c files. #38822

Splike opened this issue Nov 20, 2017 · 2 comments
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
November 2017

Comments

@Splike
Copy link

Splike commented Nov 20, 2017

  • VSCode Version: 1.18.1
  • OS Version: Windows 10 (Build 1709)
  • Reproduces without extensions: Yes

Steps to Reproduce:

  1. Create 'file.c'
  2. Create any function
  3. Setting a custom color for the "types" value in the "editor.tokenColorCustomizations" setting, will not overwrite the type color for .c files.

This behavior is very strange, as the other variables: "comments", "functions", "keywords", "numbers", "strings" and "variables", all work for .c files.

I'm thinking that .c files are probably not the only ones where some of the colors won't be applied.
@vscodebot vscodebot bot added the workbench label Nov 20, 2017
@bpasero bpasero assigned aeschli and unassigned bpasero Nov 21, 2017
@aeschli aeschli changed the title "editor.tokenColorCustomizations" is broken for .c files. "editor.tokenColorCustomizations" for types doesn't work in .c files. Nov 21, 2017
@aeschli aeschli added this to the November 2017 milestone Nov 21, 2017
@aeschli aeschli added bug Issue identified by VS Code Team member as probable bug and removed new release labels Nov 21, 2017
@aeschli
Copy link
Contributor

aeschli commented Nov 21, 2017

Now 'types' includes all rules we use for types in the default themes.
But note that each language has their own way of giving scopes to syntax elements. If more is needed, you can directly write textMateRules as described here: https://code.visualstudio.com/docs/getstarted/themes#_customize-a-color-theme

@mjbvz
Copy link
Contributor

mjbvz commented Dec 6, 2017

Verified. Types in c use storage.type which is controlled by the keywords setting:

screen shot 2017-12-05 at 5 04 54 pm

@mjbvz mjbvz added the verified Verification succeeded label Dec 6, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
4 participants
@bpasero @aeschli @Splike @mjbvz