Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search string not seeded from selection #38854

Closed
l11vdo opened this issue Nov 21, 2017 · 6 comments
Closed

search string not seeded from selection #38854

l11vdo opened this issue Nov 21, 2017 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Milestone

Comments

@l11vdo
Copy link

l11vdo commented Nov 21, 2017

  • VSCode Version: 1.18.1
  • OS Version: windows 10

Steps to Reproduce:

  1. select a string in an open file
  2. click the magnifying glass
  3. the search string is empty

NB made sure the following was set:
"editor.find.seedSearchStringFromSelection": true

Reproduces without extensions: Yes/No

@vscodebot vscodebot bot added the search Search widget and operation issues label Nov 21, 2017
@roblourens
Copy link
Member

This is currently by design. That setting only affects the editor find widget. For search, I want to only put the text in the search viewlet when someone uses cmd+shift+f from the editor.

@roblourens roblourens added the *as-designed Described behavior is as designed label Nov 21, 2017
@csicky
Copy link

csicky commented Nov 28, 2017

I searched exactly for this and I find it closed :|
It was working exactly like @l11vdo described in the issue. I too am used to this behavior. It only stopped working since last update. If it's a new design then please bring it back with a user preference.

"editor.find.seedSearchStringFromSelection": true for me as I read, would have to set exactly what this issue describes, but it's not working, it's only for the Ctrl+F search box?

@roblourens roblourens reopened this Nov 28, 2017
@roblourens roblourens added under-discussion Issue is under discussion for relevance, priority, approach and removed *as-designed Described behavior is as designed labels Nov 28, 2017
@roblourens
Copy link
Member

Trying to make everyone happy :)

In Sublime, there is just one setting that controls this for local and global find. I think it's a valid request but it's different in vscode because there are more ways to activate the search viewlet, which I think shouldn't copy the selected text.

@csicky
Copy link

csicky commented Nov 28, 2017

I understand about the one setting, I only searched on Google and found this because it stopped working like it did before the update. After searching in the preferences I found this setting which matched the problem :)
Maybe it was a "bug" that got fixed and we got used to it? Or it just happened to work without being actually designed and documented :)

Until the update it worked like this: I have the Explorer panel open > I select a text in the editor > click on the Search icon to open Search panel > selected text from Editor is inserted by VS Code automatically into search box from Search panel

Since last update, a ~week ago, it doesn't insert the selected text int the search box and I must do 3 more steps in order to perform a search: copy selected text, select previous text in search box, paste copied text.

@roblourens
Copy link
Member

I changed it in the last update on purpose because I found it annoying when the search viewlet would take the selected text just because I wanted to check previous search results. I think it should take the text in some cases but not others.

@csicky
Copy link

csicky commented Nov 29, 2017

If possible, it would be good to have it as a preference.

@roblourens roblourens added this to the December 2017 milestone Dec 9, 2017
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Dec 9, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 23, 2018
@bpasero bpasero added the verified Verification succeeded label Feb 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants