Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch: regressions from touch refactoring #38961

Closed
bpasero opened this issue Nov 22, 2017 · 6 comments
Closed

Touch: regressions from touch refactoring #38961

bpasero opened this issue Nov 22, 2017 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority layout General VS Code workbench layout issues verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Nov 22, 2017

There are a couple of places where touch no longer seems to work:

  • to resize views by touching on sashes
  • when clicking on status bar entries
  • clicking on view headers to collapse/expand
  • the "..." in the search view to expand details
  • any input field to move focus into the input field
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority layout General VS Code workbench layout issues labels Nov 22, 2017
@isidorn
Copy link
Contributor

isidorn commented Nov 22, 2017

good catches investigating

@bpasero bpasero added this to the November 2017 milestone Nov 22, 2017
@bpasero
Copy link
Member Author

bpasero commented Nov 22, 2017

@isidorn did you mean to close this? from the change it is not so obvious how it could fix the other areas I reported

@isidorn
Copy link
Contributor

isidorn commented Nov 22, 2017

@bpasero yes. There are 2 commits attached to this issue
The issue was that the events were being canceled and being stopped from propagating. Not sure why we did that in the first place, might you know @joaomoreno as the original author?

Please note that I still see some weirdness that the touch events are not respected in vscode for the first 4, 5 touches after reload?! Though I see the same for insiders (which does not contain any of my touch work)

@bpasero
Copy link
Member Author

bpasero commented Nov 22, 2017

@isidorn ok thanks

@bpasero
Copy link
Member Author

bpasero commented Dec 5, 2017

I cannot resize split-views with touch but not sure if that is a regression.

@bpasero bpasero added the verified Verification succeeded label Dec 5, 2017
@isidorn
Copy link
Contributor

isidorn commented Dec 5, 2017

@bpasero as in the other touch issue I'll give it another spin next week with the touch laptop, not critical imho

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority layout General VS Code workbench layout issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants