Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emmet not providing suggestions in latest Insiders #38973

Closed
rwmb opened this issue Nov 22, 2017 · 3 comments
Closed

emmet not providing suggestions in latest Insiders #38973

rwmb opened this issue Nov 22, 2017 · 3 comments
Assignees
@ramya-rao-a
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues

Comments

@rwmb
Copy link

rwmb commented Nov 22, 2017

Emmet stopped working for me after the last update. I tried changing configurations but nothing worked. When I type Emmet Expand Abbreviation in the command palette it works, but the suggestions are not showing like they usually do in the stable version as shown bellow. Even deleting the folders in appdata, user and install dir did not work for me.

  • VSCode Version: 1.19.0-insiders
  • OS Version: win10

Steps to Reproduce:
clean install of code-insiders, no configuration changes:

1.type anything that would normally popup as emmet suggestion in html file
emmet-not-working

Reproduces without extensions: Yes
@vscodebot vscodebot bot added the insiders label Nov 22, 2017
@vscodebot vscodebot bot added the emmet Emmet related issues label Nov 22, 2017
@ramya-rao-a ramya-rao-a changed the title emmet not providing suggestions emmet not providing suggestions in latest Insiders Nov 24, 2017
@ramya-rao-a
Copy link
Contributor

Thanks for reporting @rwmb!

This occurs when there is no parent html node when trying to expand emmet abbreviations.
A recent refactoring caused the issue.
I have pushed in a fix.

The next Insiders build that will be out on Monday (27th Nov) will have the fix.

@ramya-rao-a ramya-rao-a added the bug Issue identified by VS Code Team member as probable bug label Nov 24, 2017
@rwmb
Copy link
Author

rwmb commented Nov 24, 2017

Amazing! Thanks for the quick solution and response @ramya-rao-a !

@ramya-rao-a
Copy link
Contributor

No problem at all @rwmb
I really appreciate you and others on Insiders using emmet.
I don't use emmet much at all, and having folks like you catch me when I make mistakes like this is very helpful.

Happy Coding!

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ramya-rao-a @rwmb