Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Excluding ./src with "Use Exclude Settings" selected #38979

Closed
kenhowardpdx opened this issue Nov 22, 2017 · 4 comments
Closed

Search Excluding ./src with "Use Exclude Settings" selected #38979

kenhowardpdx opened this issue Nov 22, 2017 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Milestone

Comments

@kenhowardpdx
Copy link

  • VSCode Version: 1.18.0
  • OS Version: macOS 10.12.6

Steps to Reproduce:

  1. open project with a src folder in root
  2. go to search pane
  3. ensure "Use Exclude Settings" is selected
  4. search for camelCase symbol in ./src folder

Reproduces without extensions: Yes

search-bug

@vscodebot vscodebot bot added the search Search widget and operation issues label Nov 22, 2017
@kenhowardpdx kenhowardpdx changed the title Search Excluding /src and ./src with "Use Exclude Settings" selected Search Excluding ./src with "Use Exclude Settings" selected Nov 22, 2017
@roblourens
Copy link
Member

Your results are in .js files, and it looks like it just doesn't work when "use exclude settings" is selected, and sure enough the output pane shows an exclusion for **/*.js. I don't see you trying it with "use exclude settings" + src so I don't know that src vs ./src makes a difference.

There must be an exclude setting in your user or workspace settings for **/*.js.

@roblourens roblourens added the info-needed Issue requires more information from poster label Nov 23, 2017
@kenhowardpdx
Copy link
Author

@roblourens I do have this:

    "files.exclude": {
        "**/.git": true,
        "**/.svn": true,
        "**/.hg": true,
        "**/CVS": true,
        "**/.DS_Store": true,
        "**/*.js": {"when": "$(basename).ts"}
    },

@kenhowardpdx
Copy link
Author

search-bug-2

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Nov 23, 2017
@roblourens roblourens added this to the November 2017 milestone Nov 23, 2017
@roblourens
Copy link
Member

Oh, I do lose the 'when' clauses when searching with ./. Thanks for the report!

@RMacfarlane RMacfarlane added the verified Verification succeeded label Dec 6, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants