Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS: updating to a newer version often means UI state is lost #39125

Closed
bpasero opened this issue Nov 25, 2017 · 2 comments
Closed

macOS: updating to a newer version often means UI state is lost #39125

bpasero opened this issue Nov 25, 2017 · 2 comments
Assignees
@bpasero
Labels
*duplicate Issue identified as a duplicate of another issue(s) electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code) workbench-state UI state across restarts

Comments

@bpasero
Copy link
Member

bpasero commented Nov 25, 2017

Since a while I notice that updating to a newer version makes all UI state lost. We explicitly call electron.session.defaultSession.flushStorageData() within quitAndInstall to prevent that. It looks like the data is not flushed in some cases.
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-state UI state across restarts labels Nov 25, 2017
@bpasero bpasero added this to the November 2017 milestone Nov 25, 2017
@bpasero bpasero self-assigned this Nov 25, 2017
bpasero added a commit that referenced this issue Nov 25, 2017
@bpasero
macOS: try to flush localStorage earlier before quitting (for #39125)
0ad3753
bpasero added a commit that referenced this issue Nov 25, 2017
@bpasero
more logging (for #39125)
f4a1677
@bpasero bpasero modified the milestones: November 2017, On Deck Nov 25, 2017
@bpasero
Copy link
Member Author

bpasero commented Nov 25, 2017 •
edited

Further testing seems to indicate that this is depending on the size of data in local storage. I can reproduce this issue with my data back to 1.18 versions, so it is not a recent issue. I can however not reproduce when running Code from a new user data directory where local storage is almost empty.

All in all, I guess #18439 would help

@bpasero bpasero removed this from the On Deck milestone Dec 7, 2017
@bpasero bpasero mentioned this issue Jan 5, 2018
Closed
@bpasero bpasero mentioned this issue Feb 12, 2018
Closed
@bpasero bpasero added upstream Issue identified as 'upstream' component related (exists outside of VS Code) electron Issues and items related to Electron labels May 11, 2018
@bpasero bpasero removed bug Issue identified by VS Code Team member as probable bug labels Sep 11, 2018
@bpasero bpasero mentioned this issue Sep 19, 2018
Closed
5 tasks
@bpasero
Copy link
Member Author

bpasero commented Oct 12, 2018

Merging into #12058

@bpasero bpasero closed this as completed Oct 12, 2018
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 12, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
*duplicate Issue identified as a duplicate of another issue(s) electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code) workbench-state UI state across restarts
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bpasero