-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Touch: clicking an action like "split editor" does it twice #39180
Comments
The issue here was that we were no longer preventing default and stop propagation of the native tap event. This casued that in the split editor case we would both react on the tap event which we generate oand on the click event which vrowser generates for the tap. |
While the split thing works, when I click on a tab close button, the editor closes and opens again. |
Pushing to next week when I have a touch laptop. |
@isidorn yeah good point could be fixed, let me verify when I got a touch device again. I am out tomorrow, so you can also check. |
I checked with latest insider on a touch laptop and could not reproduce this any more. |
@isidorn nice! |
Steps to Reproduce:
=> the editor splits twice
The text was updated successfully, but these errors were encountered: