Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch: clicking an action like "split editor" does it twice #39180

Closed
bpasero opened this issue Nov 27, 2017 · 7 comments
Closed

Touch: clicking an action like "split editor" does it twice #39180

bpasero opened this issue Nov 27, 2017 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verification-found Issue verification failed verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Nov 27, 2017

Steps to Reproduce:

  1. use a touch device
  2. open an editor
  3. touch on the "Split Editor" action

=> the editor splits twice

@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Nov 27, 2017
@isidorn isidorn added this to the November 2017 milestone Nov 27, 2017
@isidorn isidorn closed this as completed in 46842f0 Dec 1, 2017
@isidorn
Copy link
Contributor

isidorn commented Dec 1, 2017

The issue here was that we were no longer preventing default and stop propagation of the native tap event. This casued that in the split editor case we would both react on the tap event which we generate oand on the click event which vrowser generates for the tap.
I have fixed this to prevent default and stop propagating only if I have found a target to wihc hto forward the tap event. I can not blindly prevent since we also realy on native behavior (input boxes getting focused when tapped)

@bpasero
Copy link
Member Author

bpasero commented Dec 5, 2017

While the split thing works, when I click on a tab close button, the editor closes and opens again.

@bpasero bpasero reopened this Dec 5, 2017
@bpasero bpasero added the verification-found Issue verification failed label Dec 5, 2017
@isidorn
Copy link
Contributor

isidorn commented Dec 5, 2017

Pushing to next week when I have a touch laptop.

@isidorn isidorn modified the milestones: November 2017, December 2017 Dec 5, 2017
@isidorn
Copy link
Contributor

isidorn commented Jan 8, 2018

@bpasero might be a similar issue as #40616
Did you go through the use of .target? I can also take a look

@bpasero
Copy link
Member Author

bpasero commented Jan 8, 2018

@isidorn yeah good point could be fixed, let me verify when I got a touch device again. I am out tomorrow, so you can also check.

@bpasero bpasero self-assigned this Jan 8, 2018
@isidorn
Copy link
Contributor

isidorn commented Jan 9, 2018

I checked with latest insider on a touch laptop and could not reproduce this any more.

@isidorn isidorn closed this as completed Jan 9, 2018
@bpasero
Copy link
Member Author

bpasero commented Jan 9, 2018

@isidorn nice!

@mjbvz mjbvz added the verified Verification succeeded label Feb 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verification-found Issue verification failed verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants