Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not possible to use arrow keys when renaming file #39211

Closed
kohlikohl opened this issue Nov 27, 2017 · 10 comments
Closed

Not possible to use arrow keys when renaming file #39211

kohlikohl opened this issue Nov 27, 2017 · 10 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Milestone
November 2017

Comments

@kohlikohl
Copy link

  • VSCode Version: Code - Insiders 1.19.0-insider (3c47070, 2017-11-27T06:07:45.718Z)
  • OS Version: Darwin x64 16.7.0
  • Extensions:
Extension Author (truncated) Version
tslint eg2 1.0.24
prettier-vscode esb 0.26.0

Steps to Reproduce:

  1. Go to a file you want to rename
  2. Hit ENTER to switch into the rename view
  3. use left/right arrow keys to attempt to move cursor between letters
  4. cursor does not move, instead the folder tree is opened/closed

renaming

Reproduces without extensions: Yes
@vscodebot vscodebot bot added insiders editor-contrib Editor collection of extras labels Nov 27, 2017
@delgermurun
Copy link

Couldn't type o character also (although I didn't tested every key).

@kieferrm kieferrm added file-explorer Explorer widget issues and removed editor editor-contrib Editor collection of extras labels Nov 27, 2017
@SEAPUNK
Copy link

SEAPUNK commented Nov 27, 2017

i think it assumes that we're passing in a keyboard shortcut command (pressing a stops the new folder creation dialog and starts a new file creation dialog)

@kieferrm kieferrm added the bug Issue identified by VS Code Team member as probable bug label Nov 28, 2017
@bpasero
Copy link
Member

bpasero commented Nov 28, 2017

@joaomoreno this sounds like a regression from your list service changes

@bpasero bpasero assigned joaomoreno and unassigned isidorn Nov 28, 2017
@bpasero bpasero added this to the November 2017 milestone Nov 28, 2017
@isidorn isidorn mentioned this issue Nov 28, 2017
Closed
This was referenced Nov 28, 2017
Closed
Closed
Closed
@joaomoreno joaomoreno mentioned this issue Nov 29, 2017
Merged
@jpoon jpoon mentioned this issue Nov 29, 2017
Closed
@mjbvz mjbvz mentioned this issue Nov 29, 2017
Closed
@kieferrm kieferrm mentioned this issue Nov 29, 2017
Closed
@bpasero bpasero added the verified Verification succeeded label Dec 6, 2017
@SEAPUNK
Copy link

SEAPUNK commented Dec 8, 2017

It broke again.

Version 1.19.0-insider (1.19.0-insider)
d8989c9
2017-12-08T10:04:48.458Z

@SEAPUNK
Copy link

SEAPUNK commented Dec 8, 2017

Repro is not the same as OP, though: Arrow keys seem to work, but pressing letters (e.g. a perform actions instead of entering the letter 'a').

@bpasero
Copy link
Member

bpasero commented Dec 9, 2017

@SEAPUNK what action did you configure for a? Do you have any VIM extension installed?

@Narkoleptika
Copy link

I can confirm that it broke again. In addition to a, h, j, k, l, and backspace don't work while naming a file or folder.

  • VSCode Version: Code - Insiders 1.19.0-insider (d8989c9, 2017-12-08T10:09:06.896Z)
  • OS Version: Darwin x64 17.3.0
  • Extensions:
Extension Author (truncated) Version
beautify Hoo 1.1.1
output-colorizer IBM 0.1.2
vscode-docker Pet 0.0.22
code-settings-sync Sha 2.8.6
html-snippets abu 0.1.0
calculate aca 1.1.1
project-manager ale 0.23.0
django-html bib 1.2.0
django-snippets bib 1.1.0
color-info bie 0.5.0
path-intellisense chr 1.4.2
regex chr 0.1.0
gitignore cod 0.5.0
vscode-svgviewer css 1.4.3
vscode-eslint dba 1.4.3
githistory don 0.2.3
jupyter don 1.1.4
python-extension-pack don 1.0.1
octobercms-template-language dqs 0.2.1
gitlens eam 6.3.0
vscode-html-css ecm 0.1.8
php-debug fel 1.12.1
auto-close-tag for 0.5.5
auto-rename-tag for 0.0.15
MagicPython mag 1.0.12
vscode-apache mrm 1.1.1
mssql ms- 1.2.1
python ms- 0.8.0
atom-keybindings ms- 3.0.2
azure-account ms- 0.2.2
cpptools ms- 0.14.3
debugger-for-chrome msj 3.5.0
color-highlight nau 2.3.0
vetur oct 0.11.3
vscode-icons rob 7.18.1
vscode-nginx sha 0.4.1
code-spell-checker str 1.5.1
language-stylus sys 1.8.0
vscode-todo-highlight way 0.5.11
jinja who 0.0.8
change-case wma 1.0.0
markdown-all-in-one yzh 0.11.2

(1 theme extensions excluded)

@bpasero bpasero reopened this Dec 9, 2017
@bpasero bpasero removed the verified Verification succeeded label Dec 9, 2017
@joaomoreno
Copy link
Member

joaomoreno commented Dec 11, 2017 •
edited

I've submitted VSCodeVim/Vim#2213 which will update the VIM extension.

The correct when clause to use now is: listFocus && !inputFocus.

@joaomoreno joaomoreno added the verified Verification succeeded label Dec 11, 2017
@SEAPUNK
Copy link

SEAPUNK commented Dec 11, 2017 •
edited

@bpasero I'm using atom keybindings. Disabling the plugin fixes my issue.

@joaomoreno
Copy link
Member

Oh, it seems @auchenberg already fixed this in microsoft/vscode-atom-keybindings#44, for the Atom keybindings. Thanks @auchenberg!

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
8 participants
@joaomoreno @delgermurun @bpasero @kohlikohl @isidorn @SEAPUNK @kieferrm @Narkoleptika