Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot read property 'document' of undefined #39413

Closed
bpasero opened this issue Dec 1, 2017 · 0 comments
Closed

Cannot read property 'document' of undefined #39413

bpasero opened this issue Dec 1, 2017 · 0 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues verified Verification succeeded
Milestone
November 2017

Comments

@bpasero
Copy link
Member

bpasero commented Dec 1, 2017

I just had "preview" enabled and clicked on many typescript files rapidly so that they changed a lot. The console shows:

TypeError: Cannot read property 'document' of undefined
	at ManagedFileContextManager.onDidChangeActiveTextEditor (/Users/bpasero/Development/Microsoft/monaco/extensions/typescript/out/utils/managedFileContext.js:26:61)
	at Emitter.fire (/Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/event.js:107:41)
	at /Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/api/node/extHostTextEditors.js:24:131
	at Emitter.fire (/Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/event.js:104:38)
	at ExtHostDocumentsAndEditors.$acceptDocumentsAndEditorsDelta (/Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/api/node/extHostDocumentsAndEditors.js:78:51)
	at ExtHostThreadService.AbstractThreadService.invoke (/Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/thread/node/abstractThreadService.js:29:27)
	at RPCProtocol._invokeHandler (/Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/extensions/node/rpcProtocol.js:81:66)
	at RPCProtocol._receiveOneMessage (/Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/extensions/node/rpcProtocol.js:70:47)
	at /Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/extensions/node/rpcProtocol.js:16:92
	at /Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/extensions/node/rpcProtocol.js:118:21
@bpasero bpasero added the typescript Typescript support issues label Dec 1, 2017
@mjbvz mjbvz mentioned this issue Dec 1, 2017
Closed
@mjbvz mjbvz closed this as completed in eaa1fe4 Dec 1, 2017
mjbvz added a commit to mjbvz/vscode that referenced this issue Dec 1, 2017
@mjbvz
Mark onDidChangeActiveTextEditor can fire with undefined
56c9f11 
From microsoft#39413

**Bug**
onDidChangeActiveTextEditor may fire with undefined for the editor. This is not currently marked in the API
@mjbvz mjbvz mentioned this issue Dec 1, 2017
Merged
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Dec 3, 2017
@bpasero bpasero added this to the November 2017 milestone Dec 3, 2017
@bpasero bpasero added the verified Verification succeeded label Dec 5, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues verified Verification succeeded
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
2 participants
@bpasero @mjbvz