Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking the profile canvas in Running Extensions doesn't select the row #39616

Closed
joaomoreno opened this issue Dec 5, 2017 · 4 comments
Closed

Clicking the profile canvas in Running Extensions doesn't select the row #39616

joaomoreno opened this issue Dec 5, 2017 · 4 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
November 2017

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Dec 5, 2017 •
edited

Testing #39568

Click the canvas with the mouse:

screen shot 2017-12-05 at 09 58 59

Same goes for right click: no context menu
@isidorn isidorn removed their assignment Dec 5, 2017
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Dec 5, 2017
@alexdima alexdima added this to the November 2017 milestone Dec 5, 2017
@alexdima
Copy link
Member

alexdima commented Dec 7, 2017

I believe this is a bug in the list. That is an <svg> element and we don't have any mouse / click listeners where we would prevent default or anything in the runtimeExtensionsEditor.ts.

@alexdima alexdima assigned joaomoreno and unassigned alexdima Dec 7, 2017
@alexdima alexdima removed this from the November 2017 milestone Dec 7, 2017
@joaomoreno
Copy link
Member Author

joaomoreno commented Dec 7, 2017 •
edited

@alexandrudima SVG automatically captures mouse events. Get a pointer-events: none; in there, yo.

@joaomoreno
Copy link
Member Author

I just pushed that line.

@joaomoreno joaomoreno added this to the November 2017 milestone Dec 7, 2017
@alexdima
Copy link
Member

alexdima commented Dec 7, 2017

wow, good to know! thanks!

@mjbvz mjbvz added the verified Verification succeeded label Dec 7, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
4 participants
@joaomoreno @isidorn @alexdima @mjbvz