Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter log calls in JS #39641

Closed
alexdima opened this issue Dec 5, 2017 · 0 comments
Closed

Filter log calls in JS #39641

alexdima opened this issue Dec 5, 2017 · 0 comments
Assignees
@joaomoreno
Labels
log VS Code log issues perf
Milestone
November 2017

Comments

@alexdima
Copy link
Member

alexdima commented Dec 5, 2017

Testing #39572

From looking at the code, I think it would be better if the loglevel would be checked in the JS side of things (to save a string.format call and a C++ call).
@sandy081 sandy081 added log VS Code log issues perf labels Dec 5, 2017
@joaomoreno joaomoreno added this to the November 2017 milestone Dec 5, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
log VS Code log issues perf
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
3 participants
@joaomoreno @alexdima @sandy081