Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only show Report Issue link when the manifest has one #39817

Closed
seanmcbreen opened this issue Dec 6, 2017 · 2 comments
Closed

Only show Report Issue link when the manifest has one #39817

seanmcbreen opened this issue Dec 6, 2017 · 2 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
November 2017

Comments

@seanmcbreen
Copy link

Testing: #39568

In the view for reporitng issue we include this link even if the package.json does not profile an issues or bug link.

image

This is for: https://marketplace.visualstudio.com/items?itemName=ms-toolsai.vscode-ai

They do have a GitHub repo so we could fall back to that repo + the issues deep link i.e.
https://github.com/Microsoft/vscode-tools-for-ai/issues

Sean
@isidorn isidorn added this to the November 2017 milestone Dec 7, 2017
@isidorn isidorn closed this as completed in 7ad0e26 Dec 7, 2017
@isidorn
Copy link
Contributor

isidorn commented Dec 7, 2017

Nice catch @seanmcbreen
In this particualr case the problem was that my string magic was cutting of the end of their repo url. That is now fixed.
Apart from that if the xtension is external and has no repo field specified aI do not show the report issue action

@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Dec 7, 2017
@ramya-rao-a
Copy link
Contributor

Verified by running from source

@ramya-rao-a ramya-rao-a added the verified Verification succeeded label Dec 7, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
4 participants
@seanmcbreen @isidorn @alexdima @ramya-rao-a