Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use cursor keys in breakpoint rename input box #39855

Closed
joaomoreno opened this issue Dec 7, 2017 · 2 comments
Closed

Can't use cursor keys in breakpoint rename input box #39855

joaomoreno opened this issue Dec 7, 2017 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@joaomoreno
Copy link
Member

This is a general problem with the ListService and using context keys to deal with each command's enablement.

The explorer (or rather workbench tress) does it in a very strange and specific way: it reacts on tree focus, selection and highlight changes and updates the list is focused context key with a debounce of 50ms.

The right way to do this is to have a global context key which is set to true every time you're in an input or textarea. That way we could fix this for every workbench list and tree.

cc @bpasero @isidorn

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug workbench labels Dec 7, 2017
@joaomoreno joaomoreno added this to the November 2017 milestone Dec 7, 2017
@joaomoreno joaomoreno self-assigned this Dec 7, 2017
@joaomoreno
Copy link
Member Author

@bpasero This fix also removes the 50ms debouncing. Can you review?

@bpasero
Copy link
Member

bpasero commented Dec 7, 2017

@joaomoreno I left some comments

@weinand weinand added the verified Verification succeeded label Dec 7, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants