Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSS tool fails for v8-inspect-profiler #39898

Closed
alexdima opened this issue Dec 7, 2017 · 1 comment
Closed

OSS tool fails for v8-inspect-profiler #39898

alexdima opened this issue Dec 7, 2017 · 1 comment
Assignees
@jrieken
Labels
engineering VS Code - Build / issue tracking / etc.
Milestone
January 2018

Comments

@alexdima
Copy link
Member

alexdima commented Dec 7, 2017

ERROR: v8-inspect-profiler@0.0.6: No license detail found at repositoryURL: null

Problems:

  • the package.json lacks a repositoryURL
  • it is not under /Microsoft/
@alexdima alexdima added this to the November 2017 milestone Dec 7, 2017
jrieken added a commit that referenced this issue Dec 8, 2017
@jrieken
depend on 0.0.7 of inspect-profiler, #39898
6ebc440
@jrieken
Copy link
Member

jrieken commented Dec 8, 2017

the package.json lacks a repositoryURL

Pushed a new version with a repo-url and updated our dependency to 0.0.7

it is not under /Microsoft/

It where it is because I was able to create it under MSFT... Not sure that's vital for the OSS tool

@jrieken jrieken added the engineering VS Code - Build / issue tracking / etc. label Dec 8, 2017
@alexdima alexdima modified the milestones: November 2017, December 2017 Dec 8, 2017
@jrieken jrieken closed this as completed Dec 8, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
2 participants
@jrieken @alexdima