Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing Latency: unnecessary Suggest Model tokenization #40040

Closed
rebornix opened this issue Dec 11, 2017 · 0 comments
Closed

Typing Latency: unnecessary Suggest Model tokenization #40040

rebornix opened this issue Dec 11, 2017 · 0 comments
Assignees
@rebornix
Labels
editor-contrib Editor collection of extras perf
Milestone
January 2018

Comments

@rebornix
Copy link
Member

  • VSCode Version: 1.19-Insiders
  • OS Version: macOS

Reproduce steps:

  • Turn on file auto save.
  • Type

image

We tried to validate the line tokens and check whether we should trigger Suggest View update immediately after typing. Since we always update the view in a delayed way, the validation doesn't need to be synchronous as well.
@rebornix rebornix added editor-contrib Editor collection of extras perf labels Dec 11, 2017
@rebornix rebornix added this to the December 2017 milestone Dec 11, 2017
@rebornix rebornix self-assigned this Dec 11, 2017
@vscodebot vscodebot bot added the insiders label Dec 11, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
editor-contrib Editor collection of extras perf
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
1 participant
@rebornix