Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent buttons on warning dialogs #40224

Closed
kieferrm opened this issue Dec 14, 2017 · 6 comments
Closed

Inconsistent buttons on warning dialogs #40224

kieferrm opened this issue Dec 14, 2017 · 6 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-notifications Notification widget issues
Milestone
February 2018

Comments

@kieferrm
Copy link
Member

  • VSCode Version: Code 1.19.0 (816be67, 2017-12-14T12:06:44.860Z)
  • OS Version: Windows_NT ia32 10.0.16299

The warning messages we show to users should use consistent labels for buttons and should also be order the same where it makes sense. See the following example:

screenshot

I propose

  • to use Never Show Again
  • to show Never Show Again right of Close, i.e. to not show an message again is a more deliberate motion than just clicking the right-most button.

We should think about enforcing the sequence of buttons in our code. I.e. shape the methods/APIs to declare whether a well-known button should be shown or not rather than where it should be shown.
@vscodebot vscodebot bot added workbench workbench-notifications Notification widget issues labels Dec 14, 2017
@bpasero
Copy link
Member

bpasero commented Dec 15, 2017 •
edited

@kieferrm all of that will change with the new notification UX, you should join our UX call next time @stevencl presents it.

@bpasero bpasero added the feature-request Request for new features or functionality label Dec 15, 2017
@bpasero bpasero removed their assignment Dec 15, 2017
@bpasero bpasero removed the workbench label Dec 19, 2017
@bpasero bpasero self-assigned this Jan 16, 2018
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Jan 16, 2018
@bpasero bpasero added this to the January 2018 milestone Jan 16, 2018
@bpasero bpasero closed this as completed Jan 16, 2018
bpasero added a commit that referenced this issue Jan 16, 2018
@bpasero
fix #40224
b939d90
@nicksnyder
Copy link
Contributor

you should join our UX call next time @stevencl presents it.

I would be interested in this if it hasn't already happened yet. Is there info somewhere?

@bpasero
Copy link
Member

bpasero commented Jan 17, 2018

@nicksnyder we will have a discussion in the team first, this is happen in these days. We can then share with broader community.

@aeschli
Copy link
Contributor

aeschli commented Feb 1, 2018

These are checkboxes, but just to note:

@aeschli aeschli reopened this Feb 1, 2018
@aeschli aeschli added the verification-found Issue verification failed label Feb 1, 2018
@aeschli
Copy link
Contributor

aeschli commented Feb 1, 2018

@bpasero Please close if this is as designed.

@bpasero
Copy link
Member

bpasero commented Feb 1, 2018

@aeschli thanks for the findings, lets move to Feb.

@bpasero bpasero modified the milestones: January 2018, February 2018 Feb 1, 2018
@bpasero bpasero removed the verification-found Issue verification failed label Feb 2, 2018
@bpasero bpasero closed this as completed Feb 2, 2018
bpasero added a commit that referenced this issue Feb 2, 2018
@bpasero
Inconsistent buttons on warning dialogs (fixes #40224)
0f72ca9
@octref octref added the verified Verification succeeded label Mar 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-notifications Notification widget issues
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
5 participants
@nicksnyder @bpasero @octref @kieferrm @aeschli