Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog not showing up when uninstall Vetur package. #40368

Closed
vegetarianlife opened this issue Dec 17, 2017 · 16 comments
Closed

Dialog not showing up when uninstall Vetur package. #40368

vegetarianlife opened this issue Dec 17, 2017 · 16 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) extensions Issues concerning extensions

Comments

@vegetarianlife
Copy link

  • VSCode Version: Code 1.19.0 (816be67, 2017-12-14T09:51:12.123Z)
  • OS Version: Darwin x64 17.3.0
  • Extensions:
Extension Author (truncated) Version
vscode-markdownlint Dav 0.12.0
EditorConfig Edi 0.11.1
beautify Hoo 1.1.1
vscode-docker Pet 0.0.22
html-css-class-completion Zig 1.14.0
vscode-color ans 0.4.5
npm-intellisense chr 1.3.0
path-intellisense chr 1.4.2
vue-peek dar 1.0.2
vscode-eslint dba 1.4.3
githistory don 0.2.3
gitlens eam 6.4.0
vscode-html-css ecm 0.1.8
tslint eg2 1.0.24
vscode-npm-script eg2 0.3.3
git-project-manager fel 1.4.0
auto-close-tag for 0.5.5
auto-rename-tag for 0.0.15
docthis joe 0.6.0
Angular2 joh 2.11.2
typings-autoinstaller jvi 1.2.0
vue liu 0.1.5
node-debug2 ms- 1.19.0
debugger-for-chrome msj 4.0.0
vuejs-extension-pack mub 0.3.0
vetur oct 0.11.5
java red 0.16.0
sass-indented rob 1.4.5
vscode-java-debug vsc 0.4.0
vscode-java-pack vsc 0.2.0
vscode-react-native vsm 0.5.7
JavaScriptSnippets xab 1.5.0

(3 theme extensions excluded)


Steps to Reproduce:

Reproduces without extensions: Yes/No

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Dec 17, 2017

Try deleting it from ~/.vscode/extensions
Are you having trouble uninstalling any of the other extensions?

@ramya-rao-a ramya-rao-a added the info-needed Issue requires more information from poster label Dec 17, 2017
@marswong
Copy link

marswong commented Dec 19, 2017

same problem, I even cannot uninstall any extension, any...

Code: 1.19.0
OS: macOS 10.13.2

@ramya-rao-a ramya-rao-a added the extensions Issues concerning extensions label Dec 19, 2017
@sandy081
Copy link
Member

@howilliams @marswong Can you please explain in detail about the issue.

Are you getting any errors in

  • Dev tools. Open by running command Toggle Developer Tools
  • Shared process. Open by running command Toggle Shared Process

@marswong
Copy link

@sandy081 Sorry, I cannot reproduce it now. When I try to reinstall and reuninstall extensions, it works without errors in Developer Tools and Shared Process. Are there any changes of the Extension Interface from code 1.17.0 to code 1.19.0? Cause my extensions had been installed since 1.17.0, and I never try to uninstall them until today (1.19.0). Thank you :)

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Dec 19, 2017

I'm also unable to uninstall extensions. Seems like it could be a 1.19 regression. It gets stuck saying "Uninstalling" with no errors in the developer tools. Weird I finally got it to uninstall with VS Code, but VS Code Insider is still failing. It looks like the failure is random or something. When the failure occurs, the "Are you sure you want to uninstall" popup doesn't appear, so maybe something is blocking that popup. It repros with the non-Insider VS Code again...I think this should be an easy bug for you guys to repro. I'm on Ubuntu 14 32-bit, but I've seen this with other OS's as well. I'm using the C/C++ extension (not sure if that matters).

@105th
Copy link

105th commented Dec 20, 2017

@ramya-rao-a

Try deleting it from ~/.vscode/extensions

This way helped with 'rm -rf' command, thanks a lot!

@sandy081
Copy link
Member

I see multiple users complaining about this, which we also reported internally - #39612

As @sean-mcmanus says, the dialog is not being shown and uninstall gets stuck in that state.

@bpasero @joaomoreno FYI

@sandy081
Copy link
Member

Since this is not reproducible consistently and also could be a timing issue, I would put some logs today in this flow and retry

@bpasero
Copy link
Member

bpasero commented Dec 20, 2017

I will also add some logs to the dialog usage in renderer and main side.

sandy081 added a commit that referenced this issue Dec 20, 2017
@sandy081
Copy link
Member

sandy081 commented Dec 20, 2017

Also added some logs for the uninstall lifecycle.

Please use the insiders tomorrow and check if you see this issue again. If it is, please provide us all logs.

Thanks

@bpasero bpasero changed the title I cannot uninstall Vetur package. Dialog not showing up when uninstall Vetur package. Dec 20, 2017
@bpasero bpasero self-assigned this Dec 20, 2017
@bpasero bpasero added this to the December 2017/January 2018 milestone Dec 20, 2017
@ramya-rao-a
Copy link
Contributor

One way I could repro this earlier is to have the extension code folder ($HOME/.vscode/extensions/extension-to-be-uninstalled) opened and then try to uninstall the extension. Since the files to be deleted are opened in vscode, uninstalling fails but doesn't tell the user that.

@sandy081
Copy link
Member

@ramya-rao-a Were you getting the dialog to uninstall in the scenario you mentioned?

image

I suspect from what users complain, it is that the above dialog itself does not appear.

@ramya-rao-a
Copy link
Contributor

@sandy081 From what I can recall, the dialog wouldn't appear. But I cannot repro this any more in stable or insiders

@bartoszdurda
Copy link

I have the same problem, dialog doesn't appear, uninstalling label is disabled and after vscode restart extension is still installed. I observed this bug occurs in current version when i'm trying to uninstall extension immediately after vscode restart. If i wait some time after vscode was launched, it works and the dialog appears properly. This scenario happens on 3 PC which i have tried. For me insiders version works good.

@bpasero
Copy link
Member

bpasero commented Dec 28, 2017

@bartoszdurda thanks for the missing hint here how to reproduce! I can reproduce as well in stable when pressing the uninstall button quickly enough after starting up and I would guess the underlying issue is again the delayed startup of the shared process (which @alexandrudima reverted in insiders via #40425).

@sandy081 this seems unrelated to any dialog changes after all

@bpasero bpasero removed their assignment Dec 28, 2017
@bpasero bpasero removed the info-needed Issue requires more information from poster label Dec 28, 2017
@sandy081
Copy link
Member

sandy081 commented Jan 8, 2018

@bartoszdurda Thanks for the hint.

@bpasero So #40425 is the root cause of this.

Since #40425 reverted and this is no longer happening in insiders, closing this issue. I also associated this to the issue #40505 that is to revisit delaying startup of shared process.

@sandy081 sandy081 closed this as completed Jan 8, 2018
@sandy081 sandy081 added the *duplicate Issue identified as a duplicate of another issue(s) label Jan 8, 2018
@sandy081 sandy081 removed this from the January 2018 milestone Jan 10, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) extensions Issues concerning extensions
Projects
None yet
Development

No branches or pull requests

8 participants