-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialog not showing up when uninstall Vetur package. #40368
Comments
Try deleting it from |
same problem, I even cannot uninstall any extension, any... Code: 1.19.0 |
@howilliams @marswong Can you please explain in detail about the issue. Are you getting any errors in
|
@sandy081 Sorry, I cannot reproduce it now. When I try to reinstall and reuninstall extensions, it works without errors in |
I'm also unable to uninstall extensions. Seems like it could be a 1.19 regression. It gets stuck saying "Uninstalling" with no errors in the developer tools. Weird I finally got it to uninstall with VS Code, but VS Code Insider is still failing. It looks like the failure is random or something. When the failure occurs, the "Are you sure you want to uninstall" popup doesn't appear, so maybe something is blocking that popup. It repros with the non-Insider VS Code again...I think this should be an easy bug for you guys to repro. I'm on Ubuntu 14 32-bit, but I've seen this with other OS's as well. I'm using the C/C++ extension (not sure if that matters). |
This way helped with 'rm -rf' command, thanks a lot! |
I see multiple users complaining about this, which we also reported internally - #39612 As @sean-mcmanus says, the dialog is not being shown and uninstall gets stuck in that state. @bpasero @joaomoreno FYI |
Since this is not reproducible consistently and also could be a timing issue, I would put some logs today in this flow and retry |
I will also add some logs to the dialog usage in renderer and main side. |
Also added some logs for the uninstall lifecycle. Please use the insiders tomorrow and check if you see this issue again. If it is, please provide us all logs. Thanks |
One way I could repro this earlier is to have the extension code folder ($HOME/.vscode/extensions/extension-to-be-uninstalled) opened and then try to uninstall the extension. Since the files to be deleted are opened in vscode, uninstalling fails but doesn't tell the user that. |
@ramya-rao-a Were you getting the dialog to uninstall in the scenario you mentioned? I suspect from what users complain, it is that the above dialog itself does not appear. |
@sandy081 From what I can recall, the dialog wouldn't appear. But I cannot repro this any more in stable or insiders |
I have the same problem, dialog doesn't appear, uninstalling label is disabled and after vscode restart extension is still installed. I observed this bug occurs in current version when i'm trying to uninstall extension immediately after vscode restart. If i wait some time after vscode was launched, it works and the dialog appears properly. This scenario happens on 3 PC which i have tried. For me insiders version works good. |
@bartoszdurda thanks for the missing hint here how to reproduce! I can reproduce as well in stable when pressing the uninstall button quickly enough after starting up and I would guess the underlying issue is again the delayed startup of the shared process (which @alexandrudima reverted in insiders via #40425). @sandy081 this seems unrelated to any dialog changes after all |
@bartoszdurda Thanks for the hint. @bpasero So #40425 is the root cause of this. Since #40425 reverted and this is no longer happening in insiders, closing this issue. I also associated this to the issue #40505 that is to revisit delaying startup of shared process. |
(3 theme extensions excluded)
Steps to Reproduce:
Reproduces without extensions: Yes/No
The text was updated successfully, but these errors were encountered: