Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension recommendation badge doesn't respect foreground color #40549

Closed
usernamehw opened this issue Dec 20, 2017 · 0 comments
Closed

Extension recommendation badge doesn't respect foreground color #40549

usernamehw opened this issue Dec 20, 2017 · 0 comments
Assignees
@ramya-rao-a
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions themes Color theme issues verified Verification succeeded
Milestone
January 2018

Comments

@usernamehw
Copy link
Contributor

It uses background but ignores foreground:

"extensionButton.prominentBackground": "#ddd",
"extensionButton.prominentForeground": "#000",

new_badge
@vscodebot vscodebot bot added the themes Color theme issues label Dec 20, 2017
@sandy081 sandy081 assigned ramya-rao-a and unassigned sandy081 Dec 20, 2017
@ramya-rao-a ramya-rao-a added extensions Issues concerning extensions bug Issue identified by VS Code Team member as probable bug labels Dec 28, 2017
ramya-rao-a added a commit that referenced this issue Dec 28, 2017
@ramya-rao-a
Use foregroundColor from theme for recommendation badge #40549
5952159
@ramya-rao-a ramya-rao-a added this to the December 2017/January 2018 milestone Dec 28, 2017
@bpasero bpasero added the verified Verification succeeded label Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions themes Color theme issues verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
4 participants
@bpasero @usernamehw @sandy081 @ramya-rao-a