Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seti file icons are no longer shown #40636

Closed
mattacosta opened this issue Dec 21, 2017 · 5 comments
Closed

Seti file icons are no longer shown #40636

mattacosta opened this issue Dec 21, 2017 · 5 comments
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
January 2018

Comments

@mattacosta
Copy link
Contributor

  • VSCode Version: Code - Insiders 1.20.0-insider (8f015e5, 2017-12-21T08:34:32.639Z)
  • OS Version: Windows_NT x64 10.0.16299
  • Extensions: none
    (1 theme extensions excluded)

Steps to reproduce:

  1. Select the Seti (Visual Studio Code) file icon theme.

There is still an offset for the icon on tabs, but not in the explorer tree.
Selecting None or Minimal still works normally.
@vscodebot vscodebot bot added themes Color theme issues insiders labels Dec 21, 2017
@Nickforall
Copy link

I am having the same problem with Material Icon Theme.

@aeschli
Copy link
Contributor

aeschli commented Dec 21, 2017

@Nickforall Please report that against https://github.com/PKief/vscode-material-icon-theme

@aeschli
Copy link
Contributor

aeschli commented Dec 21, 2017

The seti font issue is caused by jesseweed/seti-ui#464

@aeschli aeschli added this to the December 2017/January 2018 milestone Dec 21, 2017
@aeschli
Copy link
Contributor

aeschli commented Dec 21, 2017

I patched the seti font on our side and pushed the fix.

@Nickforall
Copy link

Nickforall commented Dec 21, 2017 via email

@usernamehw usernamehw mentioned this issue Dec 21, 2017
Closed
@aeschli aeschli added verification-needed Verification of issue is requested bug Issue identified by VS Code Team member as probable bug labels Feb 1, 2018
@bpasero bpasero added the verified Verification succeeded label Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
4 participants
@bpasero @mattacosta @Nickforall @aeschli