Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[seti] ts icon should be blue #40691

Closed
aneteanetes opened this issue Dec 22, 2017 · 6 comments
Closed

[seti] ts icon should be blue #40691

aneteanetes opened this issue Dec 22, 2017 · 6 comments
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug themes Color theme issues verified Verification succeeded
Milestone
January 2018

Comments

@aneteanetes
Copy link

You're my boy, Blue!

  • VSCode Version: 1.20.0-insider
  • OS Version: Windows 10 1709 (16299.125)

Please, return back dark-cyan color for *.ts files, Yellow really annoying.
@vscodebot vscodebot bot added the insiders label Dec 22, 2017
@vscodebot vscodebot bot added the workbench label Dec 22, 2017
@bpasero bpasero assigned aeschli and unassigned bpasero Dec 22, 2017
@bpasero bpasero added themes Color theme issues and removed insiders labels Dec 22, 2017
@aeschli
Copy link
Contributor

aeschli commented Jan 11, 2018

This happened when seti added a yellow icon for .spec.ts.

@aeschli aeschli changed the title New *.ts icon is Ugly! [seti] ts icon should be blue Jan 11, 2018
@aeschli aeschli added this to the January 2018 milestone Jan 11, 2018
@aeschli aeschli added the bug Issue identified by VS Code Team member as probable bug label Jan 11, 2018
@vvs vvs mentioned this issue Jan 13, 2018
Closed
@bpasero
Copy link
Member

bpasero commented Feb 1, 2018

Still yellow for me:

image

@bpasero bpasero reopened this Feb 1, 2018
@bpasero bpasero added the verification-found Issue verification failed label Feb 1, 2018
@aeschli
Copy link
Contributor

aeschli commented Feb 1, 2018

@bpasero I don't see this. Are you sure you are on the latest? You should also see an icon for test.jsonc

@aeschli
Copy link
Contributor

aeschli commented Feb 1, 2018

Ah, spec.ts is should be yellow, as defined in the seti theme: https://github.com/jesseweed/seti-ui/blob/16dc5ccb7db6329f99c20c75fc7b536965765a96/styles/components/icons/mapping.less#L315

@aeschli
Copy link
Contributor

aeschli commented Feb 1, 2018

IMO all is fine. @bpasero Please reverify: .ts should be blue .spec.ts yellow

@aeschli aeschli removed the verification-found Issue verification failed label Feb 1, 2018
@bpasero
Copy link
Member

bpasero commented Feb 1, 2018

Yeah that is what I see.

@bpasero bpasero closed this as completed Feb 1, 2018
@bpasero bpasero added the verified Verification succeeded label Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug themes Color theme issues verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
3 participants
@bpasero @aeschli @aneteanetes