Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectBox Custom, List: Low contrast for foreground, hover colors in Light themes #40731

Closed
cleidigh opened this issue Dec 22, 2017 · 2 comments · Fixed by #40914
Closed

SelectBox Custom, List: Low contrast for foreground, hover colors in Light themes #40731

cleidigh opened this issue Dec 22, 2017 · 2 comments · Fixed by #40914
Assignees
@bpasero @cleidigh
Labels
bug Issue identified by VS Code Team member as probable bug themes Color theme issues verified Verification succeeded
Milestone
January 2018

Comments

@cleidigh
Copy link
Contributor

Light themes have relatively low contrast for foreground and hover colors.
ideally we do not need to create a new color. Either we can tweak the default list colors
which are used for quick pick , SelectBox, Explorer et cetera.

Light Default:

image

Bad Hover contrast:

image

I suggest we increase the contrast for the default listHoverBackground applicable to all users.

For the foreground color we could make this slightly darker again for the default.

I don't see why we would create new colors either, I think whatever is good for selectBox should be the same and good for the quick pick

Tagging this "under discussion" hopefully that is correct.
@vscodebot vscodebot bot added the themes Color theme issues label Dec 22, 2017
@cleidigh cleidigh added the under-discussion Issue is under discussion for relevance, priority, approach label Dec 22, 2017
@cleidigh cleidigh changed the title SelectBox Custom, List: Low contrast for foreground, hover colors SelectBox Custom, List: Low contrast for foreground, hover colors in Light themes Dec 22, 2017
@cleidigh
Copy link
Contributor Author

cleidigh commented Dec 22, 2017 •
edited

@weinand
@bpasero

I finally figured out the listFocusForeground has no default, it's inherited from Monaco-shell.
If we define it and listFocusHover in light-defaults we won't create any other colors.
Screenshot does not do justice to foreground, you probably want to try it on your own machines.
Let me know what you guys think.

Below light+ with foreground, hover darkened:
foreground === #454545 originally #6c6c6c
hover === #e8e8e8

image

@bpasero
Copy link
Member

bpasero commented Dec 28, 2017

@cleidigh can you make a PR for me to try out your suggested color change?

@cleidigh cleidigh mentioned this issue Dec 28, 2017
Merged
cleidigh added a commit that referenced this issue Jan 3, 2018
@cleidigh
🔧 Monokai Dimmed & Light Themes - Increase hover contrast. Fixes: #40731
4173c64 
, #40732 (#40914)

* Monokai Dimmed & Light Themes - Increase foreground, hover contrast

* Increase listHover contrast Monokai Dimmed, Light themes
@cleidigh cleidigh removed the under-discussion Issue is under discussion for relevance, priority, approach label Jan 3, 2018
@cleidigh cleidigh added this to the December 2017/January 2018 milestone Jan 3, 2018
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Jan 4, 2018
@roblourens roblourens added the verified Verification succeeded label Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@cleidigh cleidigh

Labels
bug Issue identified by VS Code Team member as probable bug themes Color theme issues verified Verification succeeded
Projects
None yet
Milestone
January 2018
3 participants
@roblourens @bpasero @cleidigh