Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab title control should drop actions and use commands instead #40910

Closed
isidorn opened this issue Dec 28, 2017 · 4 comments
Closed

Tab title control should drop actions and use commands instead #40910

isidorn opened this issue Dec 28, 2017 · 4 comments
Assignees
@bpasero @isidorn
Labels
debt Code quality issues
Milestone
January 2018

Comments

@isidorn
Copy link
Contributor

isidorn commented Dec 28, 2017

This would allow me to get rid of a lot of commands which are now only lying around because the tab title control needs them.
Here's an example action
@isidorn isidorn added the debt Code quality issues label Dec 28, 2017
@isidorn isidorn mentioned this issue Dec 28, 2017
Merged
@bpasero bpasero added this to the December 2017/January 2018 milestone Jan 3, 2018
@isidorn
Copy link
Contributor Author

isidorn commented Jan 3, 2018

@bpasero do you want to look into this or I can also tackle it since I have cycles this milestone?

@bpasero
Copy link
Member

bpasero commented Jan 4, 2018

@isidorn let me look into it and get back to you for help 👍

@isidorn
Copy link
Contributor Author

isidorn commented Jan 4, 2018

@bpasero sounds good, thanks

bpasero added a commit that referenced this issue Jan 4, 2018
@bpasero
use commands for editor title context menu (for #40910)
9f9046c
@bpasero bpasero closed this as completed in a88b6e1 Jan 4, 2018
@bpasero
Copy link
Member

bpasero commented Jan 4, 2018

@isidorn pushed my changes, I could get rid of some actions but others are still being used for the tool bar in the open editors view.

@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@isidorn isidorn

Labels
debt Code quality issues
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
2 participants
@bpasero @isidorn