Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We changed our default indent from spaces to tabs and should announce this properly #4113

Closed
bpasero opened this issue Mar 14, 2016 · 6 comments
Closed

We changed our default indent from spaces to tabs and should announce this properly #4113

bpasero opened this issue Mar 14, 2016 · 6 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Milestone
March 2016

Comments

@bpasero
Copy link
Member

bpasero commented Mar 14, 2016

We seem to have changed the default from 4 spaces to 4 tabs and this will cause issues for any project that left the default settings in expecting new files to get spaces and not tabs.

I hope release notes are good enough, but I have a feeling this might backfire badly to us.

Refs: #3922
@bpasero
Copy link
Member Author

bpasero commented Mar 14, 2016

One example: The typescript project uses spaces and does not configure indentation.

@alexdima
Copy link
Member

@bpasero Any suggestions? We have usually communicated breaking changes in the release notes.

For the TypeScript project the guessing should guess spaces, does it not do so?

@bpasero
Copy link
Member Author

bpasero commented Mar 14, 2016

@alexandrudima sure it does, but not for new files, so you end up polluting the workspace with partial tab partial whitespace files.

Why did we decide to change the defaults?

@alexdima
Copy link
Member

@bpasero Are you arguing we should go back to the default insertSpaces: true ?

@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Mar 14, 2016
@alexdima alexdima added this to the March 2016 milestone Mar 14, 2016
@alexdima
Copy link
Member

That is fine by me

@bpasero
Copy link
Member Author

bpasero commented Mar 14, 2016

@alexandrudima yes, now that I saw the TypeScript workspace I think that would be good.

@alexdima alexdima assigned bpasero and unassigned alexdima Mar 21, 2016
@bpasero bpasero added the verified Verification succeeded label Mar 21, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Milestone
March 2016
Development

No branches or pull requests
2 participants
@bpasero @alexdima