Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Insider's Edition update1.20.0-insider broke my snippet extensions #41207

Closed
TreTuna opened this issue Jan 5, 2018 · 12 comments
Closed

The Insider's Edition update1.20.0-insider broke my snippet extensions #41207

TreTuna opened this issue Jan 5, 2018 · 12 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug snippets verified Verification succeeded
Milestone

Comments

@TreTuna
Copy link

TreTuna commented Jan 5, 2018


Steps to Reproduce:

  1. Have React Snippets extension installed
  2. Updated to today's build of VSC Insider's edition
  3. rcc -> should have created a React Class Component, instead, it now autocompletes to "RTCIceCandidate"
  4. The snippets don't even show up in the drop-down options anymore

Gif showing that it works in regular VSC but not in newest update of Insider's edition:
https://monosnap.com/file/ptlhT48QGhBxvoeCRyRjwVh50WuYbG

When I noticed this problem I immediately tried on my other Mac that still had the previous version of Insider's on it and everything still worked there, as soon as I updated it, that one broke too.

Reproduces without extensions: Yes - Disabled all extensions except for the snippets extensions I'm using. Tried each one individually and none of them work anymore

@vscodebot vscodebot bot added extensions Issues concerning extensions insiders labels Jan 5, 2018
@TreTuna TreTuna changed the title The Insider's Edition update today broke my Snippets The Insider's Edition update1.20.0-insider broke my snippet extensions Jan 5, 2018
@kieferrm kieferrm added snippets and removed extensions Issues concerning extensions labels Jan 6, 2018
@jrieken jrieken added this to the December 2017/January 2018 milestone Jan 8, 2018
@jrieken
Copy link
Member

jrieken commented Jan 8, 2018

@TreTuna Can you check what the 'F1 > Insert Snippet' command shows? Do you find your snippet in that list? Can you share your snippet file?

@TreTuna
Copy link
Author

TreTuna commented Jan 8, 2018

@jrieken Thanks for responding.

There are no snippets found at all on my Insider's Edition VSC, however, my installation of Release VSC has them all. My snippets files are empty as I have no custom made snippets myself, all of mine come from extensions.

I have side-by-side installations of release VSC and Insider's Edition. All settings/extensions/etc are matched using the Settings Sync extension and the Insider's edition just doesn't see the snippets at all.

Insider's Edition Version 1.20.0-insider - Insert Snippet:
Insider's Edition

Release VSC Installation Version 1.19.1 - Insert Snippet:
VSC Verion 1.19.1

@jrieken
Copy link
Member

jrieken commented Jan 8, 2018

Oh, wait this is insiders vs stable, right? Both have separate locations for snippets, ~/Library/Application Support/Code - Insiders/User/snippets and ~/Library/Application Support/Code/User/snippets. You can sym-link them or copy them

@TreTuna
Copy link
Author

TreTuna commented Jan 9, 2018

Yes, this is an issue with Code Insiders 1.20.0 (the version before that worked fine), not stable VSC 1.19.1. It's also a problem with snippets from extensions and not user created ones in those files.

I have no personally created user snippets. However, to test if this was a full snippets issue or just extension snippets, I created a custom snippet real quick in Insider edition and that worked fine, however, all my snippets from extensions still are not loading in and do not work in insiders edition as of the 1.20.0 release.

@jrieken
Copy link
Member

jrieken commented Jan 9, 2018

all my snippets from extensions still are not loading in and do not work in insiders edition

Installed extensions aren't shared between insiders and stable. So those you also need to 'double' install. You can check with the extensions viewlet: Select an extension, Select Contributions and check if there is a checkmark in the snippets column in the Languages section.

screen shot 2018-01-08 at 17 13 38

@TreTuna
Copy link
Author

TreTuna commented Jan 9, 2018

All my extensions are double installed, in fact, when this issue arose I did not even have the stable version of VSC installed on either of my computers. Insiders has been stable enough for me for the last 6 months that I had deleted the Stable build. I only reinstalled it on my work machine when this happened so that I could test if they worked there and seeing that it did, I'm now working in that version until this issue is resolved with Insiders. The computer I'm typing this on (my personal MBP) still only has Insider's 1.20.0 installed, all 6 of my snippets extensions have all the checkmarks, and yet I have no snippets available for use.

@jrieken
Copy link
Member

jrieken commented Jan 9, 2018

all 6 of my snippets extensions have all the checkmarks, and yet I have no snippets available for use.

Hm, that's weird. What extensions are those? Do you get snippets from the builtin/default extensions. Like TypeScript -> Class Definition?

@TreTuna
Copy link
Author

TreTuna commented Jan 9, 2018

Here are the snippet extensions I have installed. I've used pretty much all of these for 9+ months without any issues until now.

Snippet Extensions

@TreTuna
Copy link
Author

TreTuna commented Jan 9, 2018

Here is an animated gif of scrolling through my list of available items when I press control+space. The only real snippet I have is the first sniptest there that I created specifically to see if the user added custom snippets work.

controlspacelist

@jrieken
Copy link
Member

jrieken commented Jan 9, 2018

Yeah, thanks I can now reproduce. This is a regression from a change I have made last week and affect 'some' snippets, depending on their file name. Working on a fix now

@jrieken
Copy link
Member

jrieken commented Jan 9, 2018

There is actually two issues: one is a falsy assumption that the file name denotes the target files (when it's a json file) and then there seem to be extensions that use the same file to register snippets for different languages

@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Jan 9, 2018
@jrieken jrieken closed this as completed in b10ef64 Jan 9, 2018
@TreTuna
Copy link
Author

TreTuna commented Jan 12, 2018

Just wanting to say, today's installed update fixed this issue. Thank you @jrieken for your help!

@octref octref added the verified Verification succeeded label Feb 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug snippets verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants