New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workbench.action.files.copyPathOfActiveFile is missing in 1.20 #41502
Comments
@isidorn maybe a regression from your commands work? |
Same as @Tyriar thanks for finding this. I will now go through other commands to verify I did not remove more accidentely |
Ok here are more things which I accidentely removed Edit: actually the first two have been deprecated by ben already in the past, now I just killed them for good. Will still update the docs for the saveFiles one. Edit2: @bpasero maybe I leave both save commands since maybe a lot of users use them. If we keep one which one to keep. What do you think? Edit3: will keep both |
@bpasero I have now transitioned the newly introduced ids to be short and elegant. The last commit captures that. All of these ids were not present in vscode before so we can name them as we want |
@isidorn I am not seeing any command with the ID |
@isidorn the original intent as far as I remember was to have an action that would save all files, but not untitled. As such, the save all action is not a replacement to that as it would popup a dialog asking where to save untitled files. So we should still have 2 actions, one for saving all (untitled and files) and one for files only. |
@bpasero all is good know. We will have those two different |
Oke |
Is it just me that preferred the longer command names and found the short ones to be messy? Also Make sure that the keybindings are moved over to whichever one we're keeping as I rely on the defaults for that (so I'm sure others would). |
@Tyriar we are not changing any command names, just the newly introduced ones will be short. |
@isidorn the long namespaced commands are good though, if we don't use namespaces going forward it's going the list of commands is going to be a mess. |
@Tyriar we already have some in stable which are short. For me personally one namespace makes sense, 3 are just too much and most of them are bogus. Like why have Though it is up to each command author to choose what to do, currently we do not have a vscode wide convention |
They are not duplicates. The current In cases where |
@octref you are correct. However I question how many users are relying on this behavior. I would bet not many, but I might be wrong. |
@isidorn didn't @bpasero add a bunch of keybindings to help users navigating the explorer? I think the following wouldn't work anymore:
I think the only way to do this now is via the context menu key if it's available and selecting Copy Path. |
Ok the issue is that the command now first looks at the explorer and only then at the active file. So reopening to change that. |
I have brought back the old behavior.
Apart from this I aslo noticed a simliar issue with
@bpasero can you please review / verify once the new builds are out. I have cherry picked this on top of the release branch |
Verified and reviewed (out of sources). 👍 |
@isidorn the keybinding |
@Tyriar that's a great catch. |
Double verified, I have my keybinding back 😄 🎉 |
It's in 1.19 but is gone in 1.20, this is the old keybinding:
If the command was replaced with something we should add this keybinding back.
The text was updated successfully, but these errors were encountered: