Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hot exit: adopt ITextSnapshot support #41986

Closed
bpasero opened this issue Jan 22, 2018 · 0 comments · Fixed by #42081
Closed

Hot exit: adopt ITextSnapshot support #41986

bpasero opened this issue Jan 22, 2018 · 0 comments · Fixed by #42081
Assignees
@bpasero
Labels
workbench-hot-exit Preservation of unsaved changes across restarts
Milestone
January 2018

Comments

@bpasero
Copy link
Member

bpasero commented Jan 22, 2018

A follow up from #32503

Currently hot exit backups are still using the full value when restoring the backup. We should try to adopt ITextSnapshot.

Code pointers:

  • backupFileService#parseBackupContent
  • editorAreaDropHandler#handleDirtyEditorDrop
@bpasero bpasero self-assigned this Jan 22, 2018
@bpasero bpasero added the workbench-hot-exit Preservation of unsaved changes across restarts label Jan 22, 2018
@bpasero bpasero added this to the January 2018 milestone Jan 22, 2018
bpasero added a commit that referenced this issue Jan 24, 2018
@bpasero
avoid loading entire backup content for hot exit
93f3fc7 
fixes #41986
@bpasero bpasero mentioned this issue Jan 24, 2018
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
workbench-hot-exit Preservation of unsaved changes across restarts
Projects
None yet
Milestone
January 2018
Development

Successfully merging a pull request may close this issue.

avoid loading entire backup content for hot exit microsoft/vscode
1 participant
@bpasero