Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug: replace notification about "errors in workspace" with a modal dialog #42050

Closed
bpasero opened this issue Jan 23, 2018 · 3 comments
Closed

Debug: replace notification about "errors in workspace" with a modal dialog #42050

bpasero opened this issue Jan 23, 2018 · 3 comments
Assignees
@isidorn
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded workbench-notifications Notification widget issues
Milestone
January 2018

Comments

@bpasero
Copy link
Member

bpasero commented Jan 23, 2018 •
edited

I find this flow very weird:

  • I F5 to start debug
  • I have errors in my workspace
  • a non-modal message pops up asking me if I want to debug anyway

Imho it would be tolerable to show a modal confirmation dialog in this case that asks me to proceed. Clicking on proceed would continue to debug.

/cc @weinand
@bpasero bpasero added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jan 23, 2018
@bpasero bpasero added ux User experience issues workbench-notifications Notification widget issues labels Jan 23, 2018
@isidorn
Copy link
Contributor

isidorn commented Jan 24, 2018

Showing a native modal blocking dialog here makes sense.
@weinand let me know if you have any objections?

@isidorn isidorn added this to the January 2018 milestone Jan 24, 2018
@isidorn isidorn added feature-request Request for new features or functionality verification-needed Verification of issue is requested labels Jan 25, 2018
@isidorn
Copy link
Contributor

isidorn commented Jan 25, 2018

screen shot 2018-01-25 at 17 54 02

@bpasero
Copy link
Member Author

bpasero commented Jan 25, 2018

@isidorn very cool 👍

@bpasero bpasero added the verified Verification succeeded label Jan 30, 2018
@stevencl stevencl mentioned this issue Feb 5, 2018
Closed
4 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded workbench-notifications Notification widget issues
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
2 participants
@bpasero @isidorn