Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons in multiple-level tree view are not arranged correctly in 1.20 Insider #42097

Closed
LazarusX opened this issue Jan 24, 2018 · 13 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues verified Verification succeeded
Milestone

Comments

@LazarusX
Copy link

  • VSCode Version: Code - Insiders 1.20.0-insider (6bfe9bb, 2018-01-24T06:08:23.315Z)
  • OS Version: Darwin x64 17.3.0
  • Extensions (3)
    Extension Author (truncated) Version
    azure-account ms- 0.3.0
    azure-iot-edge vsc 0.1.3
    azure-iot-toolkit vsc 0.5.0

Steps to Reproduce:

  1. Install an extension with multiple-level tree view such as Azure IoT Toolkit and Docker
  2. Expand the secondary tree.

Here is how the tree view looks like in 1.19, which is correct:
image

The tree items named "$edgeAgent", "$edgeHub", "filterModule", and "tempSensor" are all sub-tree items of "edgeDevice".

In 1.20.0 Insider, the icons for the secondary tree items are closer to the left than that for the first level, which is confusing:
image

Reproduces without extensions: N/A

@LazarusX
Copy link
Author

When the secondary level tree is not expanded, here is how it looks like in 1.19:
image

But in 1.20 Insider, icons of two first level tree items "edgedevice" and "raspberrypi" are not aligned:
image

@bpasero bpasero assigned sandy081 and unassigned bpasero Jan 25, 2018
@LazarusX
Copy link
Author

This issue can be temporarily worked around by selecting an icon theme other than the default "Seti" theme.
icon-arrangement-issue

@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues labels Jan 25, 2018
@sandy081 sandy081 added this to the January 2018 milestone Jan 25, 2018
@sandy081
Copy link
Member

I see the issue, thanks for reporting. Will fix it soon.

@sandy081
Copy link
Member

Fixed it. Please try it out in tomorrows insiders.

@LazarusX
Copy link
Author

I can verify the fix on macOS, but still reproduce the issue on Windows with the latest insiders

Version 1.20.0-insider
Commit 757ff83
Date 2018-01-29T05:13:39.772Z
Shell 1.7.9
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

image

@LazarusX
Copy link
Author

LazarusX commented Feb 1, 2018

@sandy081 Any updates? I can still reproduce this issue on Windows with the 2018-02-01's Insiders version.

@sandy081
Copy link
Member

sandy081 commented Feb 1, 2018

@LazarusX Pushed some more fixes, please check with tomorrow's insiders. Thanks/

@octref octref added the verified Verification succeeded label Feb 2, 2018
@LazarusX
Copy link
Author

LazarusX commented Feb 6, 2018

@sandy081 The issue can still be reproduced. The secondary level items are still closer to the left edge.
image

@sandy081
Copy link
Member

sandy081 commented Feb 6, 2018

@LazarusX May I know which theme are you using?

@sandy081 sandy081 reopened this Feb 6, 2018
@LazarusX
Copy link
Author

LazarusX commented Feb 6, 2018

Both the icon theme and the color theme are default (Seti/Default+). You can check my user settings below:
image

By the way, the issue can also be reproduced on macOS. Though I don't have access to my Windows machine at office right now, my settings on Windows and macOS are similar.

@sandy081
Copy link
Member

sandy081 commented Feb 6, 2018

@LazarusX That's pretty bad. Fixed it.

image

sandy081 added a commit that referenced this issue Feb 6, 2018
@LazarusX
Copy link
Author

LazarusX commented Feb 7, 2018

@sandy081 Thanks for the quick fix! I can verify that my secondary level items are arranged correctly now.

However, for tree views with only first level items with icons, when switching between different icon themes, the items can move back and forth horizontally. Is it the expected behavior? See the "Docker Images" and "IoT Hub Devices" views below:
icon-arrangement-issue

For tree views with multiple levels, the items will not move during icon theme switching.

@sandy081
Copy link
Member

sandy081 commented Feb 7, 2018

@LazarusX Hmm.. I think it is not expected. We have similar experience in File explorer

kapture 2018-02-07 at 10 10 20

Filed a new issue for that #43084.

Marking this as verified as user did.

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants