Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommendation prompt is shown for .js files #42154

Closed
egamma opened this issue Jan 25, 2018 · 3 comments
Closed

Recommendation prompt is shown for .js files #42154

egamma opened this issue Jan 25, 2018 · 3 comments
Assignees
@ramya-rao-a
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded
Milestone
January 2018

Comments

@egamma
Copy link
Member

egamma commented Jan 25, 2018

image

This prompt should only be shown when a file is open for which we have no language registered.
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Jan 25, 2018 •
edited

@egamma Can you get a consistent repro of this?
Looks like a race condition.
We do show this prompt only for files which don't have any mime type supported, and we make this check at the right point in the lifecycle.

Also did you see this on startup or later?

@egamma
Copy link
Member Author

egamma commented Jan 25, 2018

@ramya-rao-a I cannot repro reliably, but I just saw it again when opening a .json file.

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Jan 26, 2018 •
edited

We were waiting for LifecyclePhase.Eventually wrongly assuming that extensions are registered by then.

Updated to use extensionService.whenInstalledExtensionsRegistered instead

@ramya-rao-a ramya-rao-a added extensions Issues concerning extensions bug Issue identified by VS Code Team member as probable bug verified Verification succeeded labels Jan 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
2 participants
@egamma @ramya-rao-a