Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Editors: Alt-click on items should not activate editor group #42399

Closed
bpasero opened this issue Jan 30, 2018 · 8 comments
Closed

Open Editors: Alt-click on items should not activate editor group #42399

bpasero opened this issue Jan 30, 2018 · 8 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jan 30, 2018

Compared to explorer where we do not. I think you always activate the target group, even though preserveFocus is true.

@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Jan 30, 2018
@isidorn isidorn added this to the January 2018 milestone Jan 30, 2018
@isidorn
Copy link
Contributor

isidorn commented Jan 31, 2018

@bpasero what do you mean by activate group?
I see exactly the same behavior in open editors and explorer on mac with latest out of source. That is file is opened as preview and the focus is passed to the file.

@isidorn isidorn added the info-needed Issue requires more information from poster label Jan 31, 2018
@bpasero
Copy link
Member Author

bpasero commented Jan 31, 2018

@isidorn this:

image

Just compare how "Open to Side" works in Explorer vs Open Editors when invoked via Ctrl+Enter

@isidorn
Copy link
Contributor

isidorn commented Feb 1, 2018

I do not see any behavior difference between open editors and explorer. Can you please elaborate what are you trying to say?
That the open editors should not activate the group?

Keep in mind that in the explorer I have no notion of groups.

@isidorn isidorn modified the milestones: January 2018, February 2018 Feb 1, 2018
@bpasero bpasero self-assigned this Feb 1, 2018
@bpasero bpasero removed the info-needed Issue requires more information from poster label Feb 1, 2018
@bpasero
Copy link
Member Author

bpasero commented Feb 1, 2018

Needs more thinking, the activate group call is there for a reason because if you click on an editor in the "open editors" view which is already opened, nothing would happen, so we need to manually activate the group the editor is in.

@aeschli
Copy link
Contributor

aeschli commented Mar 1, 2018

@bpasero Steps to verify?

@bpasero
Copy link
Member Author

bpasero commented Mar 1, 2018

@aeschli trigger "Open to Side" via keybinding (Ctrl+Enter) and verify that the editor that opens is not getting activated (same as explorer).

@octref
Copy link
Contributor

octref commented Mar 2, 2018

I don't see any difference between pressing Ctrl-Enter on a file in open editors or explorer. However @bpasero it seems the current behavior is exactly the reverse of what you want?

  • Open foo.ts
  • Focus on foo.ts in either Open Editor or Explorer
  • Ctrl-Enter
  • foo.ts is open in editor group 2 and given focus (I guess that's what you meant by "activate"?)

@bpasero
Copy link
Member Author

bpasero commented Mar 2, 2018

@octref @aeschli sorry, got confused. This is actually about Alt-click to open to side, it should not activate.

@octref octref changed the title Open Editors: "Open to Side" with keyboard still activates group Open Editors: Alt-click on items should not activate editor group Mar 2, 2018
@octref octref added the verified Verification succeeded label Mar 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants