Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry as admin message goes in loop when selected Retry as admin #42424

Closed
sandy081 opened this issue Jan 30, 2018 · 3 comments
Closed

Retry as admin message goes in loop when selected Retry as admin #42424

sandy081 opened this issue Jan 30, 2018 · 3 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-run-as-admin Issues concerning running as administrator
Milestone
January 2018

Comments

@sandy081
Copy link
Member

Testing #40592

Linux

  • Have a file sample.txt that has write permissions only for admin users
  • From a guest user, open this file in two VS Code windows
  • Edit this file in both windows
  • Save it from the first window (Use Retry as Admin option)
  • Try to save it from the second window which shows Retry as admin message
  • Selecting Retry as admin goes in loop.

kapture 2018-01-30 at 11 44 20
@bpasero bpasero added workbench-run-as-admin Issues concerning running as administrator bug Issue identified by VS Code Team member as probable bug labels Jan 30, 2018
@bpasero bpasero added this to the January 2018 milestone Jan 30, 2018
@bpasero
Copy link
Member

bpasero commented Jan 30, 2018

@sandy081 I could not reproduce (tried with etc/hosts file). Also, if I save from the second window I get an error first that the file has changed on disk, did you also get that?

@bpasero bpasero removed this from the January 2018 milestone Jan 30, 2018
@bpasero bpasero added info-needed Issue requires more information from poster and removed bug Issue identified by VS Code Team member as probable bug labels Jan 30, 2018
@sandy081
Copy link
Member Author

@bpasero I did not get the file has changed on disk error. May be do following

  • Save it from first window (You see the message to retry as admin)
  • Save it from second window (You see the message to retry as admin)
  • From the first window, retry as admin.
  • From the second window, retry as admin

@bpasero bpasero added this to the January 2018 milestone Jan 31, 2018
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Jan 31, 2018
@bpasero
Copy link
Member

bpasero commented Jan 31, 2018

Great catch.

@bpasero bpasero closed this as completed Jan 31, 2018
bpasero added a commit that referenced this issue Jan 31, 2018
@bpasero
fix #42424
4af3a00
@tsalinger tsalinger added the verified Verification succeeded label Feb 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-run-as-admin Issues concerning running as administrator
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
3 participants
@bpasero @sandy081 @tsalinger