Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changing the Twitter feedback setting has no immediate effect #42429

Closed
weinand opened this issue Jan 30, 2018 · 4 comments
Closed

changing the Twitter feedback setting has no immediate effect #42429

weinand opened this issue Jan 30, 2018 · 4 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
January 2018

Comments

@weinand
Copy link
Contributor

weinand commented Jan 30, 2018 •
edited

testing #41189 on Windows:

I was surprised that changing the setting "workbench.statusBar.feedback.visible" has no affect and requires a reload. Enabling the settings is immediate.

Since most other settings have an immediate effect, we should consider to show an alert.

A consequence of this issue is the following:

  • set setting to false (Smiley still shows)
  • click on Smiley to open form:
    2018-01-30_12-02-38

Observe: checkbox does not reflect the state of the setting.
@weinand
Copy link
Contributor Author

weinand commented Jan 30, 2018 •
edited

While continuing testing I noticed that in some situations the Smiley disappears correctly when the setting is changed to false.
So, it seems that the intent is to update immediately.

@bpasero
Copy link
Member

bpasero commented Jan 30, 2018

@weinand it will have an effect once you close the feedback dialog. can you try again with the settings opened at the same time to verify that something gets written? this might be a file watcher problem then in the end.

@bpasero bpasero added the info-needed Issue requires more information from poster label Jan 30, 2018
@weinand
Copy link
Contributor Author

weinand commented Jan 30, 2018 •
edited

@bpasero yes, on closing the feedback form the visibility of the Smiley is updated correctly.
The initial problem occurs when I change the setting via the settings editor.

@bpasero bpasero added this to the January 2018 milestone Jan 30, 2018
@bpasero bpasero added workbench-feedback and removed info-needed Issue requires more information from poster labels Jan 30, 2018
@chrmarti chrmarti mentioned this issue Jan 30, 2018
Closed
@bpasero
Copy link
Member

bpasero commented Jan 30, 2018

Good catch 👍

@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Jan 30, 2018
@bpasero bpasero closed this as completed Jan 30, 2018
bpasero added a commit that referenced this issue Jan 30, 2018
@bpasero
fix #42429
4b7917d
@weinand weinand added the verified Verification succeeded label Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
2 participants
@bpasero @weinand