Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema improvments for "localizations" #42448

Closed
isidorn opened this issue Jan 30, 2018 · 0 comments
Closed

Schema improvments for "localizations" #42448

isidorn opened this issue Jan 30, 2018 · 0 comments
Assignees
@sandy081
Labels
feature-request Request for new features or functionality l10n-platform Localization platform issues (not wrong translations) verification-needed Verification of issue is requested verified Verification succeeded
Milestone
February 2018

Comments

@isidorn
Copy link
Contributor

isidorn commented Jan 30, 2018

Refs: #42324

  1. Open package.json of your extension
  2. Do the "localizations" section
  3. Notice the following:
  • None of the fields appear as mandatory ( I would expect that at least languageId is mandatory)
  • Default object proposed for "localizations" is an empty object. This could instead have some default content which is necessery
  • Same for object inside "translations", id and path seem to be mandatory and the default object should contain them
@isidorn isidorn added the feature-request Request for new features or functionality label Jan 30, 2018
@dbaeumer dbaeumer assigned sandy081 and unassigned dbaeumer Jan 30, 2018
@sandy081 sandy081 added the l10n-platform Localization platform issues (not wrong translations) label Jan 30, 2018
@sandy081 sandy081 added this to the February 2018 milestone Jan 30, 2018
@sandy081 sandy081 added the verification-needed Verification of issue is requested label Feb 27, 2018
@bpasero bpasero added the verified Verification succeeded label Mar 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
feature-request Request for new features or functionality l10n-platform Localization platform issues (not wrong translations) verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
4 participants
@bpasero @isidorn @dbaeumer @sandy081