Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call the value first instead of never for editor.selectSuggestions #42477

Closed
sandy081 opened this issue Jan 30, 2018 · 1 comment
Closed

Call the value first instead of never for editor.selectSuggestions #42477

sandy081 opened this issue Jan 30, 2018 · 1 comment
Assignees
@jrieken
Labels
suggest IntelliSense, Auto Complete under-discussion Issue is under discussion for relevance, priority, approach
Milestone
January 2018

Comments

@sandy081
Copy link
Member

Testing #42329

never option looks as if suggestion will never be selected. But the purpose of this setting value is to always select first suggestion (Description tells the same).

So I think it is easy to understand if we call the value first or similar that conveys the meaning directly.
@jrieken jrieken added this to the January 2018 milestone Jan 30, 2018
@jrieken jrieken added suggest IntelliSense, Auto Complete under-discussion Issue is under discussion for relevance, priority, approach labels Jan 31, 2018
@jrieken
Copy link
Member

jrieken commented Feb 1, 2018 •
edited

We came up with editor.suggestSelection and values first, recentlyUsed, recentlyUsedByPrefix

jrieken added a commit that referenced this issue Feb 1, 2018
@jrieken
more names #42477
80a11d9
@jrieken jrieken closed this as completed Feb 1, 2018
@jrieken jrieken mentioned this issue Feb 1, 2018
Closed
@Vacummus Vacummus mentioned this issue Feb 3, 2018
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
suggest IntelliSense, Auto Complete under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
2 participants
@jrieken @sandy081