Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop down does not match Monokai theme #42480

Closed
stevencl opened this issue Jan 30, 2018 · 7 comments · Fixed by #42869
Closed

Drop down does not match Monokai theme #42480

stevencl opened this issue Jan 30, 2018 · 7 comments · Fixed by #42869
Assignees
@cleidigh
Labels
bug Issue identified by VS Code Team member as probable bug dropdown DropDown (SelectBox widget) native and custom issues themes Color theme issues verified Verification succeeded
Milestone
February 2018

Comments

@stevencl
Copy link
Member

stevencl commented Jan 30, 2018 •
edited

Issue Type

Bug

Description

Open output window
Set Monokai theme
Click on drop down
There is no selection highlight shown. In other themes, the currently selected item is highlighted.

VS Code Info

VS Code version: Code - Insiders 1.20.0-insider (eed7e19, 2018-01-30T09:51:29.494Z)
OS version: Windows_NT x64 10.0.16299

System Info
Item Value
CPUs Intel(R) Core(TM) i7-3687U CPU @ 2.10GHz (4 x 2594)
Memory (System) 7.89GB (1.21GB free)
Process Argv C:\Program Files\Microsoft VS Code Insiders\Code - Insiders.exe
Screen Reader yes
VM 0%
Extensions (12)
Extension Author (truncated) Version
html-snippets abu 0.2.1
vscode-eslint dba 1.4.4
tslint eg2 1.0.24
vscode-great-icons emm 2.1.22
vscode-gutter-preview kis 0.12.2
csharp ms- 1.13.1
vs-keybindings ms- 0.1.7
vsliveshare ms- 0.1.0-preview.171
team ms- 1.122.0
debugger-for-chrome msj 4.1.0
addDocComments ste 0.0.8
cordova-tools vsm 1.3.3
Reproduces only with extensions

See the screenshot:
image
Found when testing #40589
@bpasero bpasero added themes Color theme issues bug Issue identified by VS Code Team member as probable bug labels Jan 30, 2018
@bpasero
Copy link
Member

bpasero commented Jan 31, 2018

@cleidigh I think dropdown.background is set to the same color as for the selected item

@raygervais
Copy link
Contributor

I'd like to take a crack at this issue.
Can you give some pointers such as where I need to look?

Thanks!

@bpasero
Copy link
Member

bpasero commented Feb 1, 2018

@raygervais colors are in https://github.com/Microsoft/vscode/blob/master/extensions/theme-monokai-dimmed/themes/dimmed-monokai-color-theme.json#L46

@cleidigh
Copy link
Contributor

cleidigh commented Feb 2, 2018

@raygervais
Thanks. I will review your PR when submitted.

@bpasero bpasero added the dropdown DropDown (SelectBox widget) native and custom issues label Feb 2, 2018
@bpasero bpasero mentioned this issue Feb 2, 2018
Closed
@raygervais
Copy link
Contributor

Thanks, I hope to have PR done soon.
Just did some research on the theme as well as how the new dropdown widget works.

This appears to be a Windows issue (will test on Linux as well) which I cannot reproduce on MacOS since it appears to be using Webkit defaults?

Here is what it looks like on my MacBook, and the settings I'm playing around with just to see if visual indicators are changing on UI.

screen shot 2018-02-02 at 10 08 08 am

	// Dropdown Widget
	"dropdown.background": "#414339",
	"dropdown.foreground": "#f8f8f2",
	"list.activeSelectionBackground": "#75715E",
	"list.activeSelectionForeground": "#539", // Test to see what happens :D
	"list.focusBackground": "#414339",
	"list.inactiveSelectionBackground": "#414339",
	"list.hoverBackground": "#272822",
	"list.dropBackground": "#414339",
	"list.highlightForeground": "#f8f8f2",

Likewise, I do see that @bpasero has a point, list.inactiveSelectionBackground has the same color as dropdown.background. Will try that out on a Windows Station and see from there.

@bpasero
Copy link
Member

bpasero commented Feb 2, 2018

@raygervais fyi this needs testing on Linux or Windows where the custom dropdown is used.

@raygervais
Copy link
Contributor

@bpasero, thanks for the info. Will test with Linux / Windows today

@raygervais raygervais mentioned this issue Feb 3, 2018
Merged
@cleidigh cleidigh added this to the February 2018 milestone Feb 8, 2018
cleidigh pushed a commit that referenced this issue Feb 10, 2018
@raygervais @cleidigh
Monokai: Use new dropdown.listBackground to correct contrast Fixes: #…
053da66 
…42480 (#42869)

* Updated monokai dropdown configuration to use new dropdown.listBackground property
@RMacfarlane RMacfarlane added the verified Verification succeeded label Feb 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cleidigh cleidigh

Labels
bug Issue identified by VS Code Team member as probable bug dropdown DropDown (SelectBox widget) native and custom issues themes Color theme issues verified Verification succeeded
Projects
None yet
Milestone
February 2018
Development

Successfully merging a pull request may close this issue.

Monokai: Use new dropdown.listBackground to correct contrast Fixes: #42480 raygervais/vscode
5 participants
@bpasero @stevencl @RMacfarlane @raygervais @cleidigh