Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Middleclick to close tab" shortcut assumes active file instead of clicked file tab #42518

Closed
darkvertex opened this issue Jan 30, 2018 · 4 comments
Closed

"Middleclick to close tab" shortcut assumes active file instead of clicked file tab #42518

darkvertex opened this issue Jan 30, 2018 · 4 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-tabs VS Code editor tab issues
Milestone
January 2018

Comments

@darkvertex
Copy link

  • VSCode Version: code-insiders-1.20.0-1517306054.el7.x86_64
  • OS Version: CentOS Linux release 7.4.1708 (Core)

Steps to Reproduce:

  1. Use the "split" mode to break the file panels in two.
  2. Open one file on the left, another on the right.
  3. Click inside the contents of the left file, which will make this "active" (as in, if you type anything, it types inside it.)
  4. Try to middleclick on the file tab on the right.
  5. Wonder why the heck did the left file just disappear when it was the right one that you middle-clicked on. :p

You can redo steps 3 and 4 with right and left sides respectively for the same behaviour on the opposite panel.

Does this issue occur when all extensions are disabled?: Yes
@shixu
Copy link

shixu commented Jan 30, 2018

Would like to contribute. It would be my first issue though 😁

Already cloned everything and configured my workspace and also i was able to reproduce the behaviour.

@bpasero bpasero assigned isidorn and unassigned bpasero Jan 31, 2018
@shixu
Copy link

shixu commented Jan 31, 2018

Well, I fixed it....would anyone mind to tell me how to proceed from here? (PR and so on?) 👍

shixu added a commit to shixu/vscode that referenced this issue Jan 31, 2018
@shixu
Fix microsoft#42518
c3411ac 
Middleclick closes clicked editor instead of the active one.
shixu added a commit to shixu/vscode that referenced this issue Jan 31, 2018
@shixu
Merge pull request #1 from shixu/Fix-#42518
47ecb3f 
Fix microsoft#42518
@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug workbench-tabs VS Code editor tab issues labels Jan 31, 2018
@isidorn
Copy link
Contributor

isidorn commented Jan 31, 2018

@shixu thanks for your interest however we are wrapping up our milestone which means that we are on limited time and this bug was in need of fixing so I just fixed it.
For future contributing please check out our guide which should have all the needed details
https://github.com/Microsoft/vscode/wiki/How-to-Contribute

@isidorn isidorn added this to the January 2018 milestone Jan 31, 2018
@isidorn isidorn mentioned this issue Jan 31, 2018
Closed
@darkvertex
Copy link
Author

That was quick! 👏 Thank you @isidorn and @shixu for looking into this.

@bpasero bpasero added the verified Verification succeeded label Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-tabs VS Code editor tab issues
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
4 participants
@bpasero @darkvertex @isidorn @shixu