Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing a diff editor with the x button doesn't work until you click somewhere else #42527

Closed
ggilmore opened this issue Jan 30, 2018 · 2 comments
Closed

Closing a diff editor with the x button doesn't work until you click somewhere else #42527

ggilmore opened this issue Jan 30, 2018 · 2 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
January 2018

Comments

@ggilmore
Copy link
Contributor

Issue Type

Bug

Description

  1. Have a folder in your workspace with uncomitted changes

  2. Go to the SCM viewlet and click on one of the file changes

  3. Try to close the diff editor with the 'x' button - this appear to do nothing

  4. Click anywhere else in the editor, and then hit the 'x' button - now the tab closes.

See video: https://cl.ly/1U0R3s0G451R

There is no output from the developer console.

VS Code Info

VS Code version: Code - Insiders 1.20.0-insider (8cac1ac, 2018-01-30T17:19:56.812Z)
OS version: Darwin x64 17.3.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-6567U CPU @ 3.30GHz (4 x 3300)
Load (avg) 2, 3, 3
Memory (System) 16.00GB (0.73GB free)
Process Argv /Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron /Users/ggilmore/mess/src-merge/ -add
Screen Reader no
VM 0%
Extensions: none Reproduces only with extensions
@vscodebot vscodebot bot added the workbench-diagnostics General VS Code built-in diagnostic issues label Jan 30, 2018
@bpasero bpasero assigned isidorn and unassigned bpasero Jan 31, 2018
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug and removed workbench-diagnostics General VS Code built-in diagnostic issues labels Jan 31, 2018
@isidorn isidorn added the editor-commands Editor text manipulation commands label Jan 31, 2018
@isidorn isidorn added this to the January 2018 milestone Jan 31, 2018
@isidorn isidorn mentioned this issue Jan 31, 2018
Closed
@gushuro gushuro added the verified Verification succeeded label Feb 1, 2018
@gushuro
Copy link
Contributor

gushuro commented Feb 1, 2018 •
edited

This is still an issue in today's insiders (2018-01-31T17:16:58.361Z)

@gushuro gushuro reopened this Feb 1, 2018
@gushuro gushuro removed the verified Verification succeeded label Feb 1, 2018
@bpasero bpasero removed the editor-commands Editor text manipulation commands label Feb 1, 2018
@isidorn
Copy link
Contributor

isidorn commented Feb 1, 2018

This works in latest insiders.
@bpasero please verify

@isidorn isidorn closed this as completed Feb 1, 2018
@bpasero bpasero added the verified Verification succeeded label Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
4 participants
@bpasero @isidorn @gushuro @ggilmore