Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle Output is delayed compared to 1.19 #42594

Closed
octref opened this issue Jan 31, 2018 · 2 comments
Closed

Toggle Output is delayed compared to 1.19 #42594

octref opened this issue Jan 31, 2018 · 2 comments
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug output Output channel system issues perf verified Verification succeeded
Milestone
January 2018

Comments

@octref
Copy link
Contributor

octref commented Jan 31, 2018

In 1.19, Cmd+J to toggle panel is almost instant. However today when testing #40716, I noticed Cmd+J is sometimes having a delay before performing the UI update.

Up is Stable, bottom is current.

panel
@octref octref added the perf label Jan 31, 2018
@octref octref added this to the January 2018 milestone Jan 31, 2018
@rebornix
Copy link
Member

rebornix commented Jan 31, 2018 •
edited

spdlog.flush takes about 100ms. Related to #42396.

@sandy081 sandy081 assigned sandy081 and unassigned jrieken Jan 31, 2018
@sandy081 sandy081 added the output Output channel system issues label Jan 31, 2018
sandy081 added a commit that referenced this issue Jan 31, 2018
@sandy081
#42594 Do not flush if there are no contents to flush
c362830
@sandy081 sandy081 added the bug Issue identified by VS Code Team member as probable bug label Jan 31, 2018
@sandy081
Copy link
Member

@octref Good finding

@rebornix rebornix added the verified Verification succeeded label Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug output Output channel system issues perf verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
4 participants
@rebornix @jrieken @octref @sandy081