Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keytar tests are interfering with each other #42614

Closed
alexdima opened this issue Jan 31, 2018 · 0 comments
Closed

keytar tests are interfering with each other #42614

alexdima opened this issue Jan 31, 2018 · 0 comments
Assignees
@chrmarti
Milestone
January 2018

Comments

@alexdima
Copy link
Member

alexdima commented Jan 31, 2018 •
edited

The continuous builds on Windows are running half an hour apart, so this does not reproduce on the automatic builds. However, Windows builds are running on the same physical machine.

It has happened to me both yesterday, and today, that I triggered x64 and ia32 builds at the same time. The following test has broken either the 32 bit or the 64 bit builds:

https://monacotools.visualstudio.com/Monaco/_build/index?buildId=35629

2018-01-30T09:53:28.5094602Z   3867 passing (29s)
2018-01-30T09:53:28.5094602Z   1 failing
2018-01-30T09:53:28.5094602Z 
2018-01-30T09:53:28.5104577Z   1) Keytar loads and is functional:
2018-01-30T09:53:28.5104577Z      AssertionError: null == 'bar'
2018-01-30T09:53:28.5104577Z       at Object.<anonymous> (file:///D:/work/agent1/1/s/out-build/vs/platform/credentials/test/node/keytar.test.js:64:32)
2018-01-30T09:53:28.5104577Z       at step (file:///D:/work/agent1/1/s/out-build/vs/platform/credentials/test/node/keytar.test.js:31:23)
2018-01-30T09:53:28.5104577Z       at Object.next (file:///D:/work/agent1/1/s/out-build/vs/platform/credentials/test/node/keytar.test.js:12:53)
2018-01-30T09:53:28.5114562Z       at fulfilled (file:///D:/work/agent1/1/s/out-build/vs/platform/credentials/test/node/keytar.test.js:3:58)
2018-01-30T09:53:28.5114562Z       at <anonymous>
2018-01-30T09:53:28.5114562Z

https://monacotools.visualstudio.com/Monaco/_build/index?buildId=35655

2018-01-31T09:48:30.0106346Z   3867 passing (28s)
2018-01-31T09:48:30.0106346Z   1 failing
2018-01-31T09:48:30.0106346Z 
2018-01-31T09:48:30.0116333Z   1) Keytar loads and is functional:
2018-01-31T09:48:30.0116333Z      AssertionError: null == 'bar'
2018-01-31T09:48:30.0116333Z       at Object.<anonymous> (file:///D:/work/agent2/1/s/out-build/vs/platform/credentials/test/node/keytar.test.js:64:32)
2018-01-31T09:48:30.0116333Z       at step (file:///D:/work/agent2/1/s/out-build/vs/platform/credentials/test/node/keytar.test.js:31:23)
2018-01-31T09:48:30.0116333Z       at Object.next (file:///D:/work/agent2/1/s/out-build/vs/platform/credentials/test/node/keytar.test.js:12:53)
2018-01-31T09:48:30.0116333Z       at fulfilled (file:///D:/work/agent2/1/s/out-build/vs/platform/credentials/test/node/keytar.test.js:3:58)
2018-01-31T09:48:30.0116333Z       at <anonymous>

After a brief discussion with @joaomoreno, the working theory is that these tests share the same underlying password storage and they interfere with each other.

Please fix the test to use unique names or remove the test such that it is possible to have both Windows builds running in parallel.
@chrmarti chrmarti added this to the January 2018 milestone Jan 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrmarti chrmarti

Labels
None yet
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
2 participants
@alexdima @chrmarti