Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support alt+shift+<key> and alt+ctrl+<key> sequences in terminal #42629

Closed
Yanpas opened this issue Jan 31, 2018 · 6 comments
Closed

Support alt+shift+<key> and alt+ctrl+<key> sequences in terminal #42629

Yanpas opened this issue Jan 31, 2018 · 6 comments
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
February 2018

Comments

@Yanpas
Copy link
Contributor

Yanpas commented Jan 31, 2018

  • VSCode Version: 1.19.3
  • OS Version: ubuntu 16.04

Steps to Reproduce:

  1. run terminal, hit shift + alt + 3
  2. actually alt + 3 passed to terminal

shift + alt + 3 shortcut types # in the start of a line and hits enter. Handy shortcut
@vscodebot vscodebot bot added the terminal Integrated terminal issues label Jan 31, 2018
@Tyriar
Copy link
Member

Tyriar commented Jan 31, 2018

To get the shift+alt+3 command (default workbench.action.moveEditorToThirdGroup) to work within the terminal you will need to add it to the whitelist of commands that skip the shell terminal.integrated.commandsToSkipShell.

@Tyriar Tyriar closed this as completed Jan 31, 2018
@Tyriar Tyriar added the *as-designed Described behavior is as designed label Jan 31, 2018
@Yanpas
Copy link
Contributor Author

Yanpas commented Jan 31, 2018

That didn't help

@Tyriar
Copy link
Member

Tyriar commented Feb 1, 2018

@Yanpas what do you expect to happen when you hit shift+alt+3?

@Yanpas
Copy link
Contributor Author

Yanpas commented Feb 1, 2018

I expect this:
peek 2018-02-01 13-58

@Tyriar
Copy link
Member

Tyriar commented Feb 1, 2018 •
edited

Oh, you want it send to the term. This will need to be supported upstream in xterm.js, please create an issue there. I'll leave this closed as this is a very specific request about sequence support in xterm.js.

@Yanpas Yanpas mentioned this issue Feb 1, 2018
Closed
@Tyriar Tyriar added feature-request Request for new features or functionality and removed *as-designed Described behavior is as designed labels Feb 21, 2018
@Tyriar Tyriar added this to the February 2018 milestone Feb 21, 2018
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Feb 21, 2018
@Tyriar Tyriar changed the title shift + alt + 3 shortcut doesn't work in terminal Support alt+shift+<key> and alt+ctrl+<key> sequences in terminal Feb 21, 2018
@Tyriar Tyriar reopened this Feb 21, 2018
@Tyriar
Copy link
Member

Tyriar commented Feb 21, 2018

To verifier, see xtermjs/xterm.js#1267 for key strokes outside of shift+alt+3 to test.

@Tyriar Tyriar closed this as completed in eb3d867 Feb 21, 2018
@RMacfarlane RMacfarlane added the verified Verification succeeded label Feb 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
3 participants
@Tyriar @RMacfarlane @Yanpas