Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--upload-logs not functional on Windows #42635

Closed
chrmarti opened this issue Jan 31, 2018 · 8 comments
Closed

--upload-logs not functional on Windows #42635

chrmarti opened this issue Jan 31, 2018 · 8 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
January 2018

Comments

@chrmarti
Copy link
Contributor

Issue Type

Bug

Description

Testing #42352

image

Could be nodejs/node#11656 .

VS Code Info

VS Code version: Code - Insiders 1.20.0-insider (648c46d, 2018-01-31T10:13:25.946Z)
OS version: Windows_NT x64 10.0.15063

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (4 x 2195)
Memory (System) 5.98GB (3.13GB free)
Process Argv C:\Program Files\Microsoft VS Code Insiders\Code - Insiders.exe
Screen Reader no
VM 100%
Extensions: none Reproduces only with extensions
@chrmarti chrmarti mentioned this issue Jan 31, 2018
Closed
3 tasks
@mjbvz mjbvz added this to the January 2018 milestone Jan 31, 2018
@mjbvz
Copy link
Contributor

mjbvz commented Jan 31, 2018 •
edited

electron/electron#4218

// cc @joaomoreno

@joaomoreno
Copy link
Member

Yeah, there's no stdin in the main process. That's why we have the CLI process.

@mjbvz
Copy link
Contributor

mjbvz commented Feb 1, 2018

@joaomoreno Ok. So no stdin at all, even if you manually try to configure it?

I investigated moving the upload logs confirmation prompt to the CLI process but it's not easy since we need to print the path to the logs as part of this prompt. Any alternatives?

@joaomoreno
Copy link
Member

None at all. 😢

Shouldn't you be able to print the path to the logs easily from the CLI? The same world lives there: environment service, etc.

@mjbvz mjbvz closed this as completed in d233df9 Feb 1, 2018
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Feb 1, 2018
@mjbvz mjbvz reopened this Feb 1, 2018
@mjbvz
Copy link
Contributor

mjbvz commented Feb 1, 2018 •
edited

Ok, with 1872949 I've reworked the flow to no longer use stdin because it was getting complicated. Instead we ask the user the pass in a --upload-logs=iConfirmLogsUpload command line argument once they have reviewed the logs

@mjbvz mjbvz closed this as completed Feb 1, 2018
@chrmarti
Copy link
Contributor Author

chrmarti commented Feb 2, 2018 •
edited by mjbvz

Not sure if this is from this change, but it still doesn't work:

PS C:\devel\angular-test> code-insiders.cmd --upload-logs

You are about to upload your session logs to a secure Microsoft endpoint that only Microsoft's members of the VS Code team can access.

Session logs may contain personal information such as full paths or file contents. Please review and redact your session log files here: 'C:\Users\chrmarti.REDMOND\AppData\Roaming\Code - Insiders\logs\20180201T065704'

By continuing you confirm that you have reviewed and redacted your session log files and that you agree to Microsoft using them to debug VS Code.

Please run code with '--upload-logs=iConfirmLogsUpload' to proceed with upload
PS C:\devel\angular-test> code-insiders.cmd --upload-logs=iConfirmLogsUpload

Uploading...
Error posting logs: Error: ENOENT: no such file or directory, open 'C:\Users\CHRMAR~1.RED\AppData\Local\Temp\vscode-log-uploadA7YtlR\logs.zip'
[main 10:48:21 AM] Error: ENOENT: no such file or directory, open 'C:\Users\CHRMAR~1.RED\AppData\Local\Temp\vscode-log-uploadA7YtlR\logs.zip'
    at Object.fs.openSync (fs.js:584:18)
    at Object.module.(anonymous function) [as openSync] (ELECTRON_ASAR.js:173:20)
    at Object.fs.readFileSync (fs.js:491:33)
    at Object.fs.readFileSync (ELECTRON_ASAR.js:505:29)
    at C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:208:31
    at C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:440:735
    at Object.next (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:440:840)
    at C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:84:882
    at new n.Class.derive._oncancel (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:81:234)
    at r (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:84:659)
PS C:\devel\angular-test>

@chrmarti chrmarti reopened this Feb 2, 2018
@chrmarti chrmarti added the verification-found Issue verification failed label Feb 2, 2018
@tsalinger tsalinger added verified Verification succeeded and removed verification-found Issue verification failed verified Verification succeeded labels Feb 2, 2018
@mjbvz
Copy link
Contributor

mjbvz commented Feb 2, 2018

Weird. I haven't see this on master. Let me try the latest insiders build

@mjbvz
Copy link
Contributor

mjbvz commented Feb 2, 2018

Doh! I forgot to push a local fix yesterday which probably explains why this was totally all "works on my machine". Should be fixed by 5a8934a

I'll cherry pick this to 1.20 too

@mjbvz mjbvz closed this as completed Feb 2, 2018
@chrmarti chrmarti added the verified Verification succeeded label Feb 5, 2018
@chrmarti chrmarti mentioned this issue Feb 5, 2018
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
4 participants
@joaomoreno @chrmarti @mjbvz @tsalinger