Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue reporter: Improve 'API rate limit' label #42725

Closed
aeschli opened this issue Feb 1, 2018 · 4 comments
Closed

Issue reporter: Improve 'API rate limit' label #42725

aeschli opened this issue Feb 1, 2018 · 4 comments
Assignees
@RMacfarlane
Labels
verified Verification succeeded
Milestone
January 2018

Comments

@aeschli
Copy link
Contributor

aeschli commented Feb 1, 2018

  • enter many search terms to the Issue reporter
  • at some point 'API rate limit' shows up
  • It wasn't clear to me what to do now

Ideally, this would never show up (not sure if it is feasible to use a hardcoded access token with limited capabilities)
Or, add a sentence that says that something like: 'Only 10 searches can be done within a minute'
@aeschli aeschli mentioned this issue Feb 1, 2018
Closed
@vscodebot vscodebot bot added the search Search widget and operation issues label Feb 1, 2018
@gregvanl
Copy link

gregvanl commented Feb 1, 2018 •
edited

I left this comment in the commit:
How about saying something like "GitHub query limit exceeded. Please wait."?
"API rate limit exceeded" does let the user know where the throttling occurred or what they should do.
Can the issue reporter retry the query automatically after a timeout?

@gregvanl gregvanl assigned RMacfarlane and unassigned roblourens Feb 1, 2018
@RMacfarlane
Copy link
Contributor

How about this?
image
The time until reset is calculated from a value in GitHub's response. I can redo the search after the timeout. I'm not sure what token could be hardcoded safely, so will not attempt that right now.

@RMacfarlane RMacfarlane added this to the January 2018 milestone Feb 1, 2018
@gregvanl
Copy link

gregvanl commented Feb 1, 2018 •
edited

I don't think you want to include specific numbers and timeout intervals since GitHub could change these. I would leave the message generic.

@RMacfarlane
Copy link
Contributor

Ok, I'll just change it to "GitHub query limit exceeded. Please wait."

@RMacfarlane RMacfarlane removed the search Search widget and operation issues label Feb 2, 2018
@gregvanl gregvanl added the verified Verification succeeded label Feb 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RMacfarlane RMacfarlane

Labels
verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
4 participants
@roblourens @RMacfarlane @aeschli @gregvanl