Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom tree without icons has broken indentation #42739

Closed
weinand opened this issue Feb 1, 2018 · 0 comments
Closed

Custom tree without icons has broken indentation #42739

weinand opened this issue Feb 1, 2018 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues verified Verification succeeded
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Feb 1, 2018

reproduce:

  • open a custom tree that does not use icons for its elements (e.g. process view)
  • switch "File Icon Theme" between "none" and "Seti" and observe how the icon theme affects the indentation:
    2018-02-01_15-36-09

Note how children no longer align properly depending on whether they have itself children or not.

This broken indentation makes custom trees that have no icons basically unusable (if a file icon theme is used).

Since icon support for custom trees makes it first appearance in the January milestone, many custom tree implementations will not yet provide icons. These trees will be broken for users that use file icon themes.

@weinand weinand added the bug Issue identified by VS Code Team member as probable bug label Feb 1, 2018
sandy081 added a commit that referenced this issue Feb 1, 2018
@sandy081 sandy081 added this to the January 2018 milestone Feb 1, 2018
@sandy081 sandy081 added the tree-views Extension tree view issues label Feb 1, 2018
sandy081 added a commit that referenced this issue Feb 1, 2018
@weinand weinand added the verified Verification succeeded label Feb 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants