Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: always show list of explorers on right click on explorer sashes #42770

Closed
chrisdias opened this issue Feb 1, 2018 · 6 comments
Closed
Assignees
Labels
feature-request Request for new features or functionality layout General VS Code workbench layout issues verification-found Issue verification failed verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@chrisdias
Copy link
Member

When I right click on a contributed explorer sash, i get a context menu to Hide it:

image

To unhide it, i have to know to right click on the EXPLORER area at the top of the viewlet, and then I get a nice list that I can toggle things on/off:

image

This suggestion is to show the entire context menu on the right click of any explorer sash, instead of the "Hide" context menu. This would give me as the user an indication that i can toggle explorers on/off as soon as i find the context menu.

image

@kieferrm
Copy link
Member

kieferrm commented Feb 1, 2018

We should also show the context menu in the space below the last sash when all sections are closed. For example, below Azure Storage in the screen shot below. That would align the model with what we do in the activity bar and in the panel title bar.

screen shot 2018-02-01 at 2 39 15 pm

@bpasero bpasero assigned sandy081 and unassigned bpasero Feb 2, 2018
@bpasero bpasero added the layout General VS Code workbench layout issues label Feb 2, 2018
@sandy081
Copy link
Member

sandy081 commented Feb 2, 2018

The context menu on the view title is aligned with the rest of our UI (activity bar, panels). Context menu on the empty area is good.

@sandy081 sandy081 added this to the February 2018 milestone Feb 2, 2018
@sandy081 sandy081 added the feature-request Request for new features or functionality label Feb 2, 2018
sandy081 added a commit that referenced this issue Feb 22, 2018
@sandy081
Copy link
Member

image

image

@sandy081 sandy081 added the verification-needed Verification of issue is requested label Feb 27, 2018
@bpasero
Copy link
Member

bpasero commented Feb 27, 2018

@sandy081 can we show the explorer in that list too, just disabled? a bit unexpected to not see it imho:

image

@bpasero bpasero reopened this Feb 27, 2018
@bpasero bpasero added the verification-found Issue verification failed label Feb 27, 2018
@bpasero
Copy link
Member

bpasero commented Feb 28, 2018

@sandy081 I think there is still an issue that the sort order is not reflected in the menu:

image

@bpasero bpasero reopened this Feb 28, 2018
@sandy081
Copy link
Member

It was like this from beginning. For no reason, I always show them in the default order. Change it to respect the current order.

@jrieken jrieken added the verified Verification succeeded label Mar 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality layout General VS Code workbench layout issues verification-found Issue verification failed verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants