Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No tabs: Close button closes wrong editor #42830

Closed
chrmarti opened this issue Feb 2, 2018 · 1 comment
Closed

No tabs: Close button closes wrong editor #42830

chrmarti opened this issue Feb 2, 2018 · 1 comment
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
January 2018

Comments

@chrmarti
Copy link
Contributor

chrmarti commented Feb 2, 2018

Issue Type

Bug

Description

  • "editor.showTabs": false
  • open two editors side by side
  • focus left editor
  • click on close button of right editor
    -> left editor closes

VS Code Info

VS Code version: Code - Insiders 1.20.0-insider (7636a7d, 2018-02-02T11:14:28.251Z)
OS version: Darwin x64 16.7.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
Load (avg) 3, 4, 3
Memory (System) 16.00GB (0.06GB free)
Process Argv /Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron --user-data-dir tmp/user --extensions-dir tmp/ext
Screen Reader no
VM 20%
Extensions: none Reproduces without extensions
@bpasero bpasero assigned isidorn and unassigned bpasero Feb 2, 2018
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Feb 2, 2018
@bpasero bpasero added this to the January 2018 milestone Feb 2, 2018
@isidorn isidorn closed this as completed in c1b0c29 Feb 2, 2018
isidorn added a commit that referenced this issue Feb 2, 2018
@isidorn
fixes #42830
75f367d
@isidorn
Copy link
Contributor

isidorn commented Feb 2, 2018

I have cherry picked the fix on top of the release branch.
I have also checked that the close works fine across diferent areas: command palette, open editors, tabs view title, no tabs view title.
@bpasero can you also please verify these areas with the latest fix. Thanks

@bpasero bpasero added the verified Verification succeeded label Feb 3, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
3 participants
@bpasero @isidorn @chrmarti