Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue reporter: Loading process information takes a long time #42860

Closed
kieferrm opened this issue Feb 3, 2018 · 1 comment
Closed

Issue reporter: Loading process information takes a long time #42860

kieferrm opened this issue Feb 3, 2018 · 1 comment
Assignees
@RMacfarlane
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Milestone
January 2018

Comments

@kieferrm
Copy link
Member

kieferrm commented Feb 3, 2018

Issue Type

Bug

Description

The issue reporter loads system, workspace and running process information with a single request. The later takes a long time on Windows. This can keep the user from submitting a bug report or feature request for which the running process information is unneeded.

We should split the calls and only request the process information for performance issues.

VS Code Info

VS Code version: code-oss-dev 1.21.0 (Commit unknown, Date unknown)
OS version: Windows

Reproduces without extensions
@kieferrm kieferrm added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release labels Feb 3, 2018
@kieferrm kieferrm added this to the January 2018 milestone Feb 3, 2018
@egamma
Copy link
Member

egamma commented Feb 5, 2018

FYI here some back ground on why this operation is slow on Windows #39376 (comment)

RMacfarlane pushed a commit that referenced this issue Feb 5, 2018
Issue reporter: Loading process information takes a long time, #42860
004d668
ramya-rao-a pushed a commit that referenced this issue Feb 5, 2018
@ramya-rao-a
Issue reporter: Loading process information takes a long time, #42860 (…
f2bf5fc 
…#42983)
ramya-rao-a pushed a commit that referenced this issue Feb 5, 2018
@ramya-rao-a
Issue reporter: Loading process information takes a long time, #42860 (…
ed65b83 
…#42983)
@ramya-rao-a ramya-rao-a added the verified Verification succeeded label Feb 6, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RMacfarlane RMacfarlane

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
4 participants
@egamma @RMacfarlane @kieferrm @ramya-rao-a