Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window.autoDetectHighContrast setting not visible on Windows #42946

Closed
gregvanl opened this issue Feb 5, 2018 · 1 comment
Closed

window.autoDetectHighContrast setting not visible on Windows #42946

gregvanl opened this issue Feb 5, 2018 · 1 comment
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
February 2018

Comments

@gregvanl
Copy link

gregvanl commented Feb 5, 2018

  • VSCode Version:1.19.3
  • OS Version:Windows, macOS

The description indicates this is for Windows platform High Contrast mode but the setting is explicitly not shown for Windows (see !isWIndows below) and is displayed for macOS and Linux.

		'window.autoDetectHighContrast': {
			'type': 'boolean',
			'default': true,
			'description': nls.localize('autoDetectHighContrast', "If enabled, will automatically change to high contrast theme if Windows is using a high contrast theme, and to dark theme when switching away from a Windows high contrast theme."),
			'included': !isWindows
		},
@bpasero
Copy link
Member

bpasero commented Feb 5, 2018

Good catch.

@bpasero bpasero added this to the February 2018 milestone Feb 5, 2018
bpasero added a commit that referenced this issue Feb 5, 2018
@bpasero
window.autoDetectHighContrast setting not visible on Windows (fixes #…
fe9dd56 
…42946)
@bpasero bpasero closed this as completed in 598ab8a Feb 5, 2018
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Feb 5, 2018
@gregvanl gregvanl added the verified Verification succeeded label Feb 9, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
2 participants
@bpasero @gregvanl